From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5275FC8300B for ; Thu, 30 Apr 2020 08:46:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23A8D20787 for ; Thu, 30 Apr 2020 08:46:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="rO2i6WQS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727779AbgD3Iqn (ORCPT ); Thu, 30 Apr 2020 04:46:43 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:26735 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726531AbgD3Iqm (ORCPT ); Thu, 30 Apr 2020 04:46:42 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588236401; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=D1rh6tJY9hnWVCE1CPQCFpg09ZS/wdIUqQYfo3i7A80=; b=rO2i6WQSCn70jqkwkHTOJJBoneeIiNMUkmWGxA9dWvKCF2PFQNk66C/DxWgMXHqDYxqSFwFB 6UveqxeJ7z7zsxfOI8ayDEfWcheTQvJzA9oTb8ovEqy/ktVmJMd//2J9TCa/H5wutUOnkojR 8m48XE/DkWF1tCY2XYpsYYhTVlY= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5eaa905e.7fa23da2f5e0-smtp-out-n03; Thu, 30 Apr 2020 08:46:22 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7E3D3C433BA; Thu, 30 Apr 2020 08:46:22 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 560B7C43636; Thu, 30 Apr 2020 08:46:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 560B7C43636 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: John Crispin Cc: Johannes Berg , Miles Hu , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Subject: Re: [PATCH V3 3/3] ath11k: add support for setting fixed HE rate/gi/ltf References: <20200429145708.25992-1-john@phrozen.org> <20200429145708.25992-3-john@phrozen.org> Date: Thu, 30 Apr 2020 11:46:16 +0300 In-Reply-To: <20200429145708.25992-3-john@phrozen.org> (John Crispin's message of "Wed, 29 Apr 2020 16:57:08 +0200") Message-ID: <877dxxfjjb.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org John Crispin writes: > From: Miles Hu > > This patch adds ath11k support for setting fixed HE rate/gi/ltf values that > we are now able to send to the kernel using nl80211. The added code is > reusing parts of the existing code path already used for HT/VHT. The new > helpers are symmetric to how we do it for HT/VHT. > > Signed-off-by: Miles Hu > Signed-off-by: John Crispin [...] > + if (he_ltf != 0xFF) { > + vdev_param = WMI_VDEV_PARAM_HE_LTF; > + /* start from 1 */ > + he_ltf += 1; Indentation looks weird here, but I can fix that during commit. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches