From: Kalle Valo <kvalo@codeaurora.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: yhchuang@realtek.com, linux-wireless@vger.kernel.org, pkshih@realtek.com
Subject: Re: [PATCH v3 5/8] rtw88: 8723d: 11N chips don't support LDPC
Date: Thu, 30 Apr 2020 14:55:56 +0300 [thread overview]
Message-ID: <877dxxkx0z.fsf@codeaurora.org> (raw)
In-Reply-To: <20200430105418.v3s5obb3skhv4732@linutronix.de> (Sebastian Andrzej Siewior's message of "Thu, 30 Apr 2020 12:54:18 +0200")
Sebastian Andrzej Siewior <bigeasy@linutronix.de> writes:
> On 2020-04-29 17:56:53 [+0800], yhchuang@realtek.com wrote:
>> --- a/drivers/net/wireless/realtek/rtw88/main.c
>> +++ b/drivers/net/wireless/realtek/rtw88/main.c
>> @@ -933,7 +933,7 @@ static void rtw_init_ht_cap(struct rtw_dev *rtwdev,
>> ht_cap->cap = 0;
>> ht_cap->cap |= IEEE80211_HT_CAP_SGI_20 |
>> IEEE80211_HT_CAP_MAX_AMSDU |
>> - IEEE80211_HT_CAP_LDPC_CODING |
>> + (rtw_chip_wcpu_11ac(rtwdev) ? IEEE80211_HT_CAP_LDPC_CODING : 0) |
>> (1 << IEEE80211_HT_CAP_RX_STBC_SHIFT);
>
> What about
>
> ht_cap->cap = IEEE80211_HT_CAP_SGI_20 |
> IEEE80211_HT_CAP_MAX_AMSDU |
> (1 << IEEE80211_HT_CAP_RX_STBC_SHIFT);
> if (rtw_chip_wcpu_11ac(rtwdev))
> ht_cap->cap |= IEEE80211_HT_CAP_LDPC_CODING;
> instead?
Yes, that's much better. I even missed the '?' operator in my own review
as it was not that visible.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-04-30 11:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 9:56 [PATCH v3 0/8] rtw88: 8723d: add BB related routines yhchuang
2020-04-29 9:56 ` [PATCH v3 1/8] rtw88: 8723d: Add DIG parameter yhchuang
2020-04-29 9:56 ` [PATCH v3 2/8] rtw88: 8723d: Add query_rx_desc yhchuang
2020-04-29 9:56 ` [PATCH v3 3/8] rtw88: 8723d: Add set_channel yhchuang
2020-04-30 10:50 ` Sebastian Andrzej Siewior
2020-05-04 10:45 ` Tony Chuang
2020-04-29 9:56 ` [PATCH v3 4/8] rtw88: handle C2H_CCX_TX_RPT to know if packet TX'ed successfully yhchuang
2020-04-29 9:56 ` [PATCH v3 5/8] rtw88: 8723d: 11N chips don't support LDPC yhchuang
2020-04-30 10:54 ` Sebastian Andrzej Siewior
2020-04-30 11:55 ` Kalle Valo [this message]
2020-05-04 8:38 ` Tony Chuang
2020-04-29 9:56 ` [PATCH v3 6/8] rtw88: 8723d: Add chip_ops::false_alarm_statistics yhchuang
2020-04-29 9:56 ` [PATCH v3 7/8] rtw88: 8723d: Set IG register for CCK rate yhchuang
2020-04-29 9:56 ` [PATCH v3 8/8] rtw88: 8723d: add interface configurations table yhchuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dxxkx0z.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bigeasy@linutronix.de \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).