From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BE13FC6194 for ; Fri, 8 Nov 2019 08:33:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 229A92178F for ; Fri, 8 Nov 2019 08:33:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="lJhJ3pbz"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="lJhJ3pbz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730719AbfKHIdB (ORCPT ); Fri, 8 Nov 2019 03:33:01 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:58306 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbfKHIdB (ORCPT ); Fri, 8 Nov 2019 03:33:01 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A21A360DE9; Fri, 8 Nov 2019 08:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573201980; bh=Li42Bwy0+M/BNejEX2gv6nmzcZsTnhWewqmxkM3PU/I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lJhJ3pbzgpR6MVInBNLaR4+Oew/lJpScGLOfz+fYn45tamW/Bg2PApcLKKNL5Ocex UfEfqRpaf0/wMYRy1iSN9BqsKTNN1i2eA2l8IEMfiOeEMumAOcupjZmHkCebR0mAps lnnqrE/5FclHb5DYmblpch4NYYS9+y2lKLfEXbJ0= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 728C160D85; Fri, 8 Nov 2019 08:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573201980; bh=Li42Bwy0+M/BNejEX2gv6nmzcZsTnhWewqmxkM3PU/I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lJhJ3pbzgpR6MVInBNLaR4+Oew/lJpScGLOfz+fYn45tamW/Bg2PApcLKKNL5Ocex UfEfqRpaf0/wMYRy1iSN9BqsKTNN1i2eA2l8IEMfiOeEMumAOcupjZmHkCebR0mAps lnnqrE/5FclHb5DYmblpch4NYYS9+y2lKLfEXbJ0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 728C160D85 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Ikjoon Jang Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, "David S . Miller" Subject: Re: [PATCH] ath10k: disable cpuidle during downloading firmware. References: <20191101054035.42101-1-ikjn@chromium.org> <87y2ws3lvh.fsf@kamboji.qca.qualcomm.com> Date: Fri, 08 Nov 2019 10:32:56 +0200 In-Reply-To: (Ikjoon Jang's message of "Thu, 7 Nov 2019 12:16:45 +0800") Message-ID: <877e4aydhj.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ikjoon Jang writes: > On Thu, Nov 7, 2019 at 2:23 AM Kalle Valo wrote: >> >> Ikjoon Jang writes: >> >> > Downloading ath10k firmware needs a large number of IOs and >> > cpuidle's miss predictions make it worse. In the worst case, >> > resume time can be three times longer than the average on sdio. >> > >> > This patch disables cpuidle during firmware downloading by >> > applying PM_QOS_CPU_DMA_LATENCY in ath10k_download_fw(). >> > >> > Signed-off-by: Ikjoon Jang >> >> On what hardware and firmware versions did you test this? I'll add that >> to the commit log. >> >> https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#guidelines > > Thank you for sharing it. > It's QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00029 > on ARMv8 multi cluster platform. Thanks, I added that to the commit log. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches