From: Kalle Valo <kvalo@codeaurora.org>
To: Andy Strohman <andrew@andrewstrohman.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
Andy Strohman <andy@uplevelsystems.com>
Subject: Re: [PATCH] netlink: fix station_info pertid memory leak
Date: Mon, 27 May 2019 07:16:50 +0300 [thread overview]
Message-ID: <877eacv8el.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20190525062729.8504-1-andy@uplevelsystems.com> (Andy Strohman's message of "Fri, 24 May 2019 23:27:29 -0700")
Andy Strohman <andrew@andrewstrohman.com> writes:
> When dumping stations, memory allocated for station_info's
> pertid member will leak if the nl80211 header cannot be added to
> the sk_buff due to insufficient tail room.
>
> I noticed this leak in the kmalloc-2048 cache.
>
> Fixes: 8689c051a201 ("cfg80211: dynamically allocate per-tid stats for station info")
> Signed-off-by: Andy Strohman <andy@uplevelsystems.com>
> ---
> net/wireless/nl80211.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
The correct prefix should be "nl80211:".
--
Kalle Valo
prev parent reply other threads:[~2019-05-27 4:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 6:27 [PATCH] netlink: fix station_info pertid memory leak Andy Strohman
2019-05-27 4:16 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eacv8el.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=andrew@andrewstrohman.com \
--cc=andy@uplevelsystems.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox