From: Kalle Valo <kvalo@codeaurora.org>
To: Tony Chuang <yhchuang@realtek.com>
Cc: "johannes\@sipsolutions.net" <johannes@sipsolutions.net>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"sgruszka\@redhat.com" <sgruszka@redhat.com>,
Pkshih <pkshih@realtek.com>, Andy Huang <tehuang@realtek.com>,
"briannorris\@chromium.org" <briannorris@chromium.org>,
"Larry.Finger\@lwfinger.net" <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH v8 00/14] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips
Date: Wed, 13 Mar 2019 09:10:09 +0200 [thread overview]
Message-ID: <877ed31c8e.fsf@codeaurora.org> (raw)
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D17BF35B@RTITMBSVM04.realtek.com.tw> (Tony Chuang's message of "Wed, 13 Mar 2019 07:06:24 +0000")
Tony Chuang <yhchuang@realtek.com> writes:
>> > v8
>> >
>> > - add prefix "rtw_" to *_rates and corresponding *_sizes, otherwise
>> > the extern will confuse the linker there are multiple definitions
>> > with brcmsmac driver
>>
>> I tried to explain this already last time, but maybe I wasn't clear
>> enough so I'll try again: PLEASE do not submit any new versions of rtw88
>> until I explicitly ask you to send v9. If you post new versions too
>> frequently it makes the review harder. Reviewing full driver is very
>> different from reviewing normal patches, the patches are larger and it
>> takes more time to review.
>
> Sorry about that. I thought " please fix that in the next version " was asking
> me to send the next version. Now I get it, will include these fixes in my tree,
> and send v9 until you ask to.
Great, thank you.
--
Kalle Valo
next prev parent reply other threads:[~2019-03-13 7:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 4:13 [PATCH v8 00/14] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips yhchuang
2019-03-13 4:13 ` [PATCH v8 01/14] rtw88: main files yhchuang
2019-03-15 8:28 ` Johannes Berg
2019-03-13 4:13 ` [PATCH v8 02/14] rtw88: core files yhchuang
2019-03-13 4:13 ` [PATCH v8 03/14] rtw88: hci files yhchuang
2019-03-25 14:34 ` Brian Norris
2019-03-27 5:07 ` Tony Chuang
2019-03-13 4:13 ` [PATCH v8 04/14] rtw88: trx files yhchuang
2019-03-13 4:13 ` [PATCH v8 05/14] rtw88: mac files yhchuang
2019-03-13 4:13 ` [PATCH v8 06/14] rtw88: fw and efuse files yhchuang
2019-03-13 4:13 ` [PATCH v8 07/14] rtw88: phy files yhchuang
2019-03-13 4:13 ` [PATCH v8 08/14] rtw88: debug files yhchuang
2019-03-13 4:13 ` [PATCH v8 09/14] rtw88: chip files yhchuang
2019-03-13 4:13 ` [PATCH v8 10/14] rtw88: 8822B init table yhchuang
2019-03-13 4:14 ` [PATCH v8 11/14] rtw88: 8822C " yhchuang
2019-03-13 4:14 ` [PATCH v8 12/14] rtw88: Kconfig & Makefile yhchuang
2019-03-13 4:14 ` [PATCH v8 13/14] rtw88: add MAINTAINERS entry yhchuang
2019-03-13 6:48 ` [PATCH v8 00/14] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips Kalle Valo
2019-03-13 7:06 ` Tony Chuang
2019-03-13 7:10 ` Kalle Valo [this message]
[not found] ` <1552450443-351-15-git-send-email-yhchuang@realtek.com>
2019-03-19 21:01 ` [PATCH v8 14/14] staging: rtlwifi: remove staging rtlwifi driver Kalle Valo
2019-03-25 14:36 ` [PATCH v8 00/14] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips Brian Norris
2019-03-26 7:54 ` Stanislaw Gruszka
2019-03-26 15:43 ` Brian Norris
2019-03-27 4:59 ` Tony Chuang
2019-03-27 10:26 ` Stanislaw Gruszka
2019-04-08 2:14 ` Tony Chuang
2019-04-08 11:33 ` Kalle Valo
2019-04-09 10:12 ` Tony Chuang
2019-04-18 13:55 ` Kalle Valo
2019-04-19 8:23 ` Tony Chuang
2019-04-19 21:01 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ed31c8e.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=briannorris@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=sgruszka@redhat.com \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).