From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"wcn36xx@lists.infradead.org" <wcn36xx@lists.infradead.org>,
"k.eugene.e@gmail.com" <k.eugene.e@gmail.com>
Subject: Re: [PATCH v2] wcn36xx: Fix dynamic power saving
Date: Tue, 12 Dec 2017 12:40:57 +0000 [thread overview]
Message-ID: <877etsqftz.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <87bmj4qhkm.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Tue, 12 Dec 2017 14:03:21 +0200")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
> Loic Poulain <loic.poulain@linaro.org> writes:
>
>> Since driver does not report hardware dynamic power saving cap,
>> this is up to the mac80211 to manage power saving timeout and
>> state machine, using the ieee80211 config callback to report
>> PS changes. This patch enables/disables PS mode according to
>> the new configuration.
>>
>> Remove old behaviour enabling PS mode in a static way, this make
>> the device unusable when power save is enabled since device is
>> forced to PS regardless RX/TX traffic.
>>
>> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
>
> A fixes line would be nice for backporters. I can add that but need the
> commit id.
Or maybe this actually isn't a regression? Then of course a fixes line
is not needed.
Should I push this to v4.15 or v4.16, any preference?
--=20
Kalle Valo=
next prev parent reply other threads:[~2017-12-12 12:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 8:52 [PATCH v2] wcn36xx: Fix dynamic power saving Loic Poulain
2017-12-11 15:34 ` Ramon Fried
2017-12-11 15:41 ` Bjorn Andersson
2017-12-11 17:43 ` Loic Poulain
2017-12-12 12:03 ` Kalle Valo
2017-12-12 12:40 ` Kalle Valo [this message]
2017-12-12 13:17 ` Loic Poulain
2018-01-04 16:48 ` [v2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877etsqftz.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=bjorn.andersson@linaro.org \
--cc=k.eugene.e@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).