From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:57238 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbdG1QvQ (ORCPT ); Fri, 28 Jul 2017 12:51:16 -0400 From: Kalle Valo To: Colin Ian King Cc: Stanislaw Gruszka , Helmut Schaa , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org Subject: Re: rt2x00: make const array glrt_table static References: <20170711114733.15387-1-colin.king@canonical.com> <20170728150130.336D06095E@smtp.codeaurora.org> Date: Fri, 28 Jul 2017 19:51:11 +0300 In-Reply-To: <20170728150130.336D06095E@smtp.codeaurora.org> (Kalle Valo's message of "Fri, 28 Jul 2017 15:01:30 +0000 (UTC)") Message-ID: <877eyswlmo.fsf@purkki.adurom.net> (sfid-20170728_185121_200706_9DB70F8A) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Kalle Valo writes: > Colin Ian King wrote: > >> From: Colin Ian King >> >> Don't populate array glrt_table on the stack but make it static. >> Makes the object code a smaller by over 670 bytes: >> >> Before: >> text data bss dec hex filename >> 131772 4733 0 136505 21539 rt2800lib.o >> >> After: >> text data bss dec hex filename >> 131043 4789 0 135832 21298 rt2800lib.o >> >> Signed-off-by: Colin Ian King >> Acked-by: Stanislaw Gruszka > > Patch applied to wireless-drivers-next.git, thanks. > > 17830147c40a mwifiex: fix spelling mistake: "Insuffient" -> "Insufficient" Dave had applied this earlier and my script failed to detect that. Hence the commit above is wrong. commit bf98bd0be1ba509c5e6d77524ffac192f1edb2dd Author: Colin Ian King AuthorDate: Tue Jul 11 12:47:33 2017 +0100 Commit: David S. Miller CommitDate: Thu Jul 13 09:23:56 2017 -0700 rt2x00: make const array glrt_table static -- Kalle Valo