* [PATCH] ath9k: fix AR5416 access GPIO warning
@ 2016-08-04 7:48 miaoqing
2016-08-15 10:16 ` Valo, Kalle
2016-09-02 16:34 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: miaoqing @ 2016-08-04 7:48 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, ath9k-devel, s.l-h, Miaoqing Pan
From: Miaoqing Pan <miaoqing@codeaurora.org>
The warning was seen on AR5416 chip, which invoke ath9k_hw_gio_get()
before the GPIO initialized correctly.
WARNING: CPU: 1 PID: 1159 at ~/drivers/net/wireless/ath/ath9k/hw.c:2776 ath9k_hw_gpio_get+0x148/0x1a0 [ath9k_hw]
...
CPU: 1 PID: 1159 Comm: systemd-udevd Not tainted 4.7.0-rc7-aptosid-amd64 #1 aptosid 4.7~rc7-1~git92.slh.3
Hardware name: /DH67CL, BIOS BLH6710H.86A.0160.2012.1204.1156 12/04/2012
0000000000000286 00000000f912d633 ffffffff81290fd3 0000000000000000
0000000000000000 ffffffff81063fd4 ffff88040c6dc018 0000000000000000
0000000000000002 0000000000000000 0000000000000100 ffff88040c6dc018
Call Trace:
[<ffffffff81290fd3>] ? dump_stack+0x5c/0x79
[<ffffffff81063fd4>] ? __warn+0xb4/0xd0
[<ffffffffa0668fb8>] ? ath9k_hw_gpio_get+0x148/0x1a0 [ath9k_hw]
Signed-off-by: Miaoqing Pan <miaoqing@codeaurora.org>
---
drivers/net/wireless/ath/ath9k/hw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index d1d0c06..14b13f0 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -2482,6 +2482,8 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah)
return -EINVAL;
}
+ ath9k_gpio_cap_init(ah);
+
if (AR_SREV_9485(ah) ||
AR_SREV_9285(ah) ||
AR_SREV_9330(ah) ||
@@ -2531,8 +2533,6 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah)
else
pCap->hw_caps &= ~ATH9K_HW_CAP_HT;
- ath9k_gpio_cap_init(ah);
-
if (AR_SREV_9160_10_OR_LATER(ah) || AR_SREV_9100(ah))
pCap->rts_aggr_limit = ATH_AMPDU_LIMIT_MAX;
else
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ath9k: fix AR5416 access GPIO warning
2016-08-04 7:48 [PATCH] ath9k: fix AR5416 access GPIO warning miaoqing
@ 2016-08-15 10:16 ` Valo, Kalle
2016-09-02 16:34 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Valo, Kalle @ 2016-08-15 10:16 UTC (permalink / raw)
To: miaoqing@codeaurora.org
Cc: linux-wireless@vger.kernel.org, ath9k-devel, s.l-h@gmx.de
<miaoqing@codeaurora.org> writes:
> From: Miaoqing Pan <miaoqing@codeaurora.org>
>
> The warning was seen on AR5416 chip, which invoke ath9k_hw_gio_get()
> before the GPIO initialized correctly.
>
> WARNING: CPU: 1 PID: 1159 at ~/drivers/net/wireless/ath/ath9k/hw.c:2776 ath9k_hw_gpio_get+0x148/0x1a0 [ath9k_hw]
> ...
> CPU: 1 PID: 1159 Comm: systemd-udevd Not tainted 4.7.0-rc7-aptosid-amd64 #1 aptosid 4.7~rc7-1~git92.slh.3
> Hardware name: /DH67CL, BIOS BLH6710H.86A.0160.2012.1204.1156 12/04/2012
> 0000000000000286 00000000f912d633 ffffffff81290fd3 0000000000000000
> 0000000000000000 ffffffff81063fd4 ffff88040c6dc018 0000000000000000
> 0000000000000002 0000000000000000 0000000000000100 ffff88040c6dc018
> Call Trace:
> [<ffffffff81290fd3>] ? dump_stack+0x5c/0x79
> [<ffffffff81063fd4>] ? __warn+0xb4/0xd0
> [<ffffffffa0668fb8>] ? ath9k_hw_gpio_get+0x148/0x1a0 [ath9k_hw]
>
> Signed-off-by: Miaoqing Pan <miaoqing@codeaurora.org>
As discussed in the previous thread I'll add:
Reported-by: Stefan Lippers-Hollmann <s.l-h@gmx.de>
Tested-by: Stefan Lippers-Hollmann <s.l-h@gmx.de>
Cc: <stable@vger.kernel.org> # 4.7+
I'm also planning to queue this to 4.8.
--
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ath9k: fix AR5416 access GPIO warning
2016-08-04 7:48 [PATCH] ath9k: fix AR5416 access GPIO warning miaoqing
2016-08-15 10:16 ` Valo, Kalle
@ 2016-09-02 16:34 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2016-09-02 16:34 UTC (permalink / raw)
To: miaoqing pan; +Cc: linux-wireless, ath9k-devel, s.l-h, Miaoqing Pan
miaoqing pan <miaoqing@codeaurora.org> wrote:
> From: Miaoqing Pan <miaoqing@codeaurora.org>
>
> The warning was seen on AR5416 chip, which invoke ath9k_hw_gio_get()
> before the GPIO initialized correctly.
>
> WARNING: CPU: 1 PID: 1159 at ~/drivers/net/wireless/ath/ath9k/hw.c:2776 ath9k_hw_gpio_get+0x148/0x1a0 [ath9k_hw]
> ...
> CPU: 1 PID: 1159 Comm: systemd-udevd Not tainted 4.7.0-rc7-aptosid-amd64 #1 aptosid 4.7~rc7-1~git92.slh.3
> Hardware name: /DH67CL, BIOS BLH6710H.86A.0160.2012.1204.1156 12/04/2012
> 0000000000000286 00000000f912d633 ffffffff81290fd3 0000000000000000
> 0000000000000000 ffffffff81063fd4 ffff88040c6dc018 0000000000000000
> 0000000000000002 0000000000000000 0000000000000100 ffff88040c6dc018
> Call Trace:
> [<ffffffff81290fd3>] ? dump_stack+0x5c/0x79
> [<ffffffff81063fd4>] ? __warn+0xb4/0xd0
> [<ffffffffa0668fb8>] ? ath9k_hw_gpio_get+0x148/0x1a0 [ath9k_hw]
>
> Signed-off-by: Miaoqing Pan <miaoqing@codeaurora.org>
> Reported-by: Stefan Lippers-Hollmann <s.l-h@gmx.de>
> Tested-by: Stefan Lippers-Hollmann <s.l-h@gmx.de>
Thanks, 1 patch applied to ath-current branch of ath.git:
db7b542e4a78 ath9k: fix AR5416 access GPIO warning
--
Sent by pwcli
https://patchwork.kernel.org/patch/9262875/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-02 16:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-04 7:48 [PATCH] ath9k: fix AR5416 access GPIO warning miaoqing
2016-08-15 10:16 ` Valo, Kalle
2016-09-02 16:34 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).