Re: [PATCH] bcma: fix linking problem with of_default_bus_match_table

[Kalle Valo <kvalo@codeaurora.org>]

Jonas Gorski <jogo@openwrt.org> writes:

>>> I think this isn't enough, AFAICT this needs IS_BUILTIN(CONFIG_BCMA)
>>> && IS_ENABLED(CONFIG_OF), else it will break with OF=n and BCMA=y, as
>>> of_default_bus_match_table is only defined/built-in when OF=y.
>> 
>> I just tested and OF=n and BCMA=y case built succesfully for me. I think
>> it's because of_default_bus_match_table is created even when CONFIG_OF
>> is n. Can you double check, please?
>> 
>
> Thinking more about it, I know/remember why it complies even if it
> shouldn't: the inline prototype for !OF of of_platform_populate does not
> use any of the arguments so the compiler optimises the reference out.
> So unless you compile with -O0, you are fine.

Thanks for checking. I think this is good enough for now and I'll apply
this once I get the report from kbuild.

-- 
Kalle Valo