Re: [PATCH] ath10k: fix AP/IBSS CSA with template based fw

[Kalle Valo <kvalo@qca.qualcomm.com>]

Michal Kazior <michal.kazior@tieto.com> writes:

>> I actually had strange conflicts already with this patch (in mac.c). As
>> I'm travelling, please check my resolution from the pending branch very
>> carefully. I might have done something stupid.
>
> There's a mistake. Only `arvif->is_up` should be protected by
> `ar->data_lock` in ath10k_bss_assoc():
>
> @@ -1852,7 +1901,9 @@ static void ath10k_bss_assoc(struct ieee80211_hw *hw,
>                 return;
>         }
>
> +       spin_lock_bh(&arvif->ar->data_lock);
>         arvif->is_up = true;
> +       spin_unlock_bh(&arvif->ar->data_lock);
>
>         /* Workaround: Some firmware revisions (tested with qca6174

Thanks for catching this. I fixed it now, can you please check again?

-- 
Kalle Valo