Re: [PATCH v2 5/8] ath10k: Implement sta_add_debugfs

[Kalle Valo <kvalo@qca.qualcomm.com>]

Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:

> Add per station debugfs files when a station is added to mac80211's
> station list. This helps to group peer specific debugfs entries
> altogether. Right now this callback adds support to test aggregation
> procedures (addba/addba_resp/delba) manually.
>
> To enable automatic aggregation in target,
> echo 0 >/sys/kernel/debug/ieee80211/phyX/netdev:wlanX/
> 	stations/XX:XX:XX:XX:XX:XX/aggr_mode
>
> For manual mode,
> echo 1 >/sys/kernel/debug/ieee80211/phyX/netdev:wlanX/
> 	stations/XX:XX:XX:XX:XX:XX/aggr_mode
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>

[...]

> diff --git a/drivers/net/wireless/ath/ath10k/debugfs_sta.c b/drivers/net/wireless/ath/ath10k/debugfs_sta.c
> new file mode 100644
> index 0000000..d5fca70
> --- /dev/null
> +++ b/drivers/net/wireless/ath/ath10k/debugfs_sta.c
> @@ -0,0 +1,89 @@
> +/*
> + * Copyright (c) 2014 Qualcomm Atheros, Inc.
> + *
> + * Permission to use, copy, modify, and/or distribute this software for any
> + * purpose with or without fee is hereby granted, provided that the above
> + * copyright notice and this permission notice appear in all copies.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
> + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
> + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
> + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
> + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
> + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
> + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
> + */
> +#include <linux/utsname.h>

Why include utsname.h? I don't see it used anywhere.

-- 
Kalle Valo