From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/5] ath10k: add 10.2.4 firmware support
Date: Tue, 16 Dec 2014 09:49:09 +0200 [thread overview]
Message-ID: <877fxst4p6.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1418620274-3081-2-git-send-email-rmanohar@qti.qualcomm.com> (Rajkumar Manoharan's message of "Mon, 15 Dec 2014 10:41:10 +0530")
Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
> 10.2.4 firmware uses bitmask in wmi_resource_config to configure
> 10.2 firmware features like airtime fairness and rx batch mode instead
> of maintaining separete bool entry. This allows new features that can be
> configure during init time without breaking backward compatibility.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Few comments. I'll deal with these and send v2.
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -387,6 +387,11 @@ enum ath10k_fw_features {
> */
> ATH10K_FW_FEATURE_WMI_10_2 = 4,
>
> + /* Firmware 10.2.4 supports bitmask in resource config to configure
> + * Airtime fairness and rx batch mode
> + */
> + ATH10K_FW_FEATURE_WMI_10_2_4 = 5,
When we add new value to enum ath10k_fw_wmi_op_version this flag is not
needed.
> /* keep last */
> ATH10K_FW_FEATURE_COUNT,
> };
> diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h
> index 809c252..892b6f0 100644
> --- a/drivers/net/wireless/ath/ath10k/hw.h
> +++ b/drivers/net/wireless/ath/ath10k/hw.h
> @@ -72,6 +72,7 @@ enum ath10k_fw_wmi_op_version {
> ATH10K_FW_WMI_OP_VERSION_10_1 = 2,
> ATH10K_FW_WMI_OP_VERSION_10_2 = 3,
> ATH10K_FW_WMI_OP_VERSION_TLV = 4,
> + ATH10K_FW_WMI_OP_VERSION_10_2_4 = 5,
>
> /* keep last */
> ATH10K_FW_WMI_OP_VERSION_MAX,
> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
> index fa486f6..c42382c 100644
> --- a/drivers/net/wireless/ath/ath10k/wmi.c
> +++ b/drivers/net/wireless/ath/ath10k/wmi.c
> @@ -4748,6 +4748,7 @@ static const struct wmi_ops wmi_10_2_ops = {
> int ath10k_wmi_attach(struct ath10k *ar)
> {
> switch (ar->wmi.op_version) {
> + case ATH10K_FW_WMI_OP_VERSION_10_2_4:
> case ATH10K_FW_WMI_OP_VERSION_10_2:
> ar->wmi.cmd = &wmi_10_2_cmd_map;
> ar->wmi.ops = &wmi_10_2_ops;
I think it's better to not share cmd_map/ops and instead create new ones
for 10_2_4.
--
Kalle Valo
next prev parent reply other threads:[~2014-12-16 7:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 5:11 [PATCH 0/5] ath10k: Add thermal mitigation support Rajkumar Manoharan
2014-12-15 5:11 ` [PATCH 1/5] ath10k: add 10.2.4 firmware support Rajkumar Manoharan
2014-12-16 7:49 ` Kalle Valo [this message]
2014-12-15 5:11 ` [PATCH 2/5] ath10k: add wmi support for pdev_set_quiet_mode Rajkumar Manoharan
2014-12-15 5:11 ` [PATCH 3/5] ath10k: add thermal cooling device support Rajkumar Manoharan
2014-12-16 7:45 ` Kalle Valo
2014-12-15 5:11 ` [PATCH 4/5] ath10k: add wmi interface for pdev_get_temperature Rajkumar Manoharan
2014-12-15 5:11 ` [PATCH 5/5] ath10k: add thermal sensor device support Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fxst4p6.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).