Re: [PATCH] ath10k: set the mactime of ieee80211_rx_status

[Kalle Valo <kvalo@qca.qualcomm.com>]

Chun-Yeow Yeoh <yeohchunyeow@gmail.com> writes:

> Retrieve the mactime of ieee80211_rx_status based on received
> data frame. The value is obtained from the htt_rx_indication_ppdu
> structure and only available in 32-bit.
>
> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>

Why? Where do you need tsf exactly? And what bug are you actually fixing
here?

> --- a/drivers/net/wireless/ath/ath10k/txrx.c
> +++ b/drivers/net/wireless/ath/ath10k/txrx.c
> @@ -258,6 +258,12 @@ void ath10k_process_rx(struct ath10k *ar, struct htt_rx_info *info)
>  	status->band = ch->band;
>  	status->freq = ch->center_freq;
>  
> +	if (info->rate.info0 & HTT_RX_INDICATION_INFO0_END_VALID) {
> +		/* TSF available only in 32-bit */
> +		status->mactime = info->tsf & 0xffffffff;
> +		status->flag |= RX_FLAG_MACTIME_END;
> +	}

Do we get some regressions because of proving only a 32 bit TSF? Which
one is better, provide a 32-bit TSF or not at all?

-- 
Kalle Valo