From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <greearb@candelatech.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] wmi: Handle failure to start scan.
Date: Fri, 14 Feb 2014 08:13:25 +0200 [thread overview]
Message-ID: <877g8y6x2y.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1392318594-32540-1-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Thu, 13 Feb 2014 11:09:54 -0800")
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> Properly clean up driver state in case firmware fails
> to start scan for some reason.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
Why just RFC?
And "ath10k:" prefix missing.
> --- a/drivers/net/wireless/ath/ath10k/wmi.c
> +++ b/drivers/net/wireless/ath/ath10k/wmi.c
> @@ -770,7 +770,25 @@ static int ath10k_wmi_event_scan(struct ath10k *ar, struct sk_buff *skb)
> ath10k_dbg(ATH10K_DBG_WMI, "WMI_SCAN_EVENT_PREEMPTED\n");
> break;
> case WMI_SCAN_EVENT_START_FAILED:
> - ath10k_dbg(ATH10K_DBG_WMI, "WMI_SCAN_EVENT_START_FAILED\n");
> + ath10k_warn("WMI_SCAN_EVENT_START_FAILED, reason: %i\n", reason);
"scan failed to start: %i\n"
> + ar->scan_channel = NULL;
> + if (!ar->scan.in_progress) {
> + ath10k_warn("scan-start-failed: no scan requested, ignoring\n");
"scan failed to start but no scan requested, ignoring\n"
--
Kalle Valo
next prev parent reply other threads:[~2014-02-14 6:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 19:09 [RFC] wmi: Handle failure to start scan greearb
2014-02-14 6:13 ` Kalle Valo [this message]
2014-02-14 6:47 ` Michal Kazior
2014-02-14 16:07 ` Ben Greear
2014-02-17 7:42 ` Michal Kazior
2014-02-17 16:10 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g8y6x2y.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).