From: Kalle Valo <kalle.valo@iki.fi>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linville@tuxdriver.com, luciano.coelho@nokia.com,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] wireless: wl12xx, fix lock imbalance
Date: Tue, 21 Jul 2009 12:10:14 +0300 [thread overview]
Message-ID: <877hy2qu4p.fsf@litku.valot.fi> (raw)
In-Reply-To: <4A64E199.70501@gmail.com> (Jiri Slaby's message of "Mon\, 20 Jul 2009 23\:28\:57 +0200")
Jiri Slaby <jirislaby@gmail.com> writes:
> But currently I'm confused by wl1251_plt_start and wl1251_plt_stop.
> They take a lock but doesn't unlock it at all. Neither their callies.
> Is it hidden somewhere deeper?
I guess that's a bug which creeped in when I ported the patches from our
internal tree. I'll just remove plt start/stop functions altogether,
they need to ported to the new nl80211 test mode interface anyway.
Oh damn, I just noticed that I added wl1251_netlink.c accidentally to
wireless-testing tree. It should definitely not be there, instead we
need to use nl80211 test command interface. I'll send a patch to remove
the private netlink stuff soon. John, sorry about this.
--
Kalle Valo
prev parent reply other threads:[~2009-07-21 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 20:37 [PATCH v2] wireless: wl12xx, fix lock imbalance Jiri Slaby
2009-07-15 5:41 ` Luciano Coelho
2009-07-16 9:09 ` Kalle Valo
2009-07-20 21:28 ` Jiri Slaby
2009-07-21 9:10 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hy2qu4p.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=luciano.coelho@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).