From: Kalle Valo <Kalle.Valo@nokia.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Jiri Benc <jbenc@suse.cz>, Michael Wu <flamingice@sourmilk.net>,
Michael Buesch <mb@bu3sch.de>
Subject: Re: mac80211 AP mode powersaving problems?
Date: Wed, 29 Aug 2007 17:32:38 +0300 [thread overview]
Message-ID: <877inev2bd.fsf@nokia.com> (raw)
In-Reply-To: <1188349109.7837.147.camel@johannes.berg> (ext Johannes Berg's message of "Wed\, 29 Aug 2007 02\:58\:29 +0200")
Johannes Berg <johannes@sipsolutions.net> writes:
> Good news.
Really good news!
>> But that's not all, also multicast frames (including ARP broadcast)
>> are not buffered correctly. They are sent randomly instead of directly
>> after a DTIM beacon. Also Multicast bit is not set and DTIM is always
>> zero even though DTIM period is two.
>
> Actually, they were sent right away because we enqueued them to queue
> zero, not queue four.
Yeah, I meant randomly relative to a DTIM beacon.
> Please try the attached patches. I haven't implemented the set_tim()
> callback yet, but the device should now wake up for multicast traffic,
> not for unicast yet. The patches work for me on a heavily patched kernel
> ('everything' plus http://johannes.sipsolutions.net/patches/kernel/all/)
Applied 055-b43-timb-position.patch and 057-b43-mcast.patch to commit
0347a7c86f. Multicast is buffered correctly and N800 sees them. Also
DTIM count and multicast bit are now correct in beacons.
--
Kalle Valo
next prev parent reply other threads:[~2007-08-29 14:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-13 7:35 mac80211 AP mode powersaving problems? Johannes Berg
2007-08-16 5:43 ` Kalle Valo
2007-08-16 13:21 ` Johannes Berg
2007-08-16 14:31 ` Kalle Valo
2007-08-16 14:42 ` Johannes Berg
[not found] ` <86wsvv8m9t.fsf@coulee.tdb.com>
2007-08-16 17:02 ` Johannes Berg
2007-08-16 18:37 ` Russell Senior
2007-08-17 10:14 ` Johannes Berg
2007-08-27 15:58 ` Kalle Valo
2007-08-28 8:48 ` Johannes Berg
2007-08-28 10:59 ` Kalle Valo
2007-08-28 11:05 ` Johannes Berg
2007-08-28 11:11 ` Kalle Valo
2007-08-28 16:06 ` Kalle Valo
2007-08-28 16:18 ` Johannes Berg
2007-08-28 18:08 ` Kalle Valo
2007-08-28 18:43 ` Johannes Berg
2007-08-29 4:18 ` Kalle Valo
2007-08-29 8:37 ` Johannes Berg
2007-08-29 14:35 ` Kalle Valo
2007-08-30 11:56 ` Johannes Berg
2007-08-29 0:12 ` Johannes Berg
2007-08-29 0:58 ` Johannes Berg
2007-08-29 10:11 ` Johannes Berg
2007-08-29 17:50 ` Michael Buesch
2007-08-30 11:54 ` Johannes Berg
2007-08-29 14:32 ` Kalle Valo [this message]
2007-08-30 11:55 ` Johannes Berg
2007-08-22 7:49 ` b43 vs. the TIM (was: mac80211 AP mode powersaving problems?) Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877inev2bd.fsf@nokia.com \
--to=kalle.valo@nokia.com \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).