From: Kalle Valo <kvalo@kernel.org>
To: Baochen Qiang <quic_bqiang@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/6] wifi: ath11k: move some firmware stats related functions outside of debugfs
Date: Thu, 14 Nov 2024 13:34:05 +0200 [thread overview]
Message-ID: <878qtm1236.fsf@kernel.org> (raw)
In-Reply-To: <7917a344-82aa-4ef8-9558-554743c5dd15@quicinc.com> (Baochen Qiang's message of "Thu, 14 Nov 2024 14:05:28 +0800")
Baochen Qiang <quic_bqiang@quicinc.com> writes:
> On 11/13/2024 7:14 PM, Kalle Valo wrote:
>> Baochen Qiang <quic_bqiang@quicinc.com> writes:
>>
>>> Commit b488c766442f ("ath11k: report rssi of each chain to mac80211 for QCA6390/WCN6855")
>>> and commit c3b39553fc77 ("ath11k: add signal report to mac80211 for QCA6390 and WCN6855")
>>> call debugfs functions in mac ops. Those functions are no-ops if CONFIG_ATH11K_DEBUGFS is
>>> not enabled, thus cause wrong status reported.
>>
>> What do you mean exactly with wrong status reported?
>
> ah, thanks for pointing that. actually no wrong values reported, since
> we are not even reporting anything in that case. will be accurate.
>
>>
>> mac.c is quite large already, making it even bigger is something I would
>> like to avoid.
>
> then can you suggest any other place?
I first need to understand the issue we are fixing. Is it ath11k does
not report rssi and signal via ath11k_mac_op_sta_statistics() when
CONFIG_ATH11K_DEBUGFS is disabled?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-11-14 11:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 1:56 [PATCH 0/6] wifi: ath11k: fixes and refactor to firmware stats related functions Baochen Qiang
2024-11-13 1:56 ` [PATCH 1/6] wifi: ath11k: avoid burning CPU in ath11k_debugfs_fw_stats_request() Baochen Qiang
2024-11-13 11:12 ` Kalle Valo
2024-11-14 5:34 ` Baochen Qiang
2024-11-13 1:56 ` [PATCH 2/6] wifi: ath11k: don't use static variables in ath11k_debugfs_fw_stats_process() Baochen Qiang
2024-11-13 11:15 ` Kalle Valo
2024-11-13 1:56 ` [PATCH 3/6] wifi: ath11k: move some firmware stats related functions outside of debugfs Baochen Qiang
2024-11-13 11:14 ` Kalle Valo
2024-11-14 6:05 ` Baochen Qiang
2024-11-14 11:34 ` Kalle Valo [this message]
2024-11-15 1:46 ` Baochen Qiang
2024-11-13 1:56 ` [PATCH 4/6] wifi: ath11k: adjust unlock sequence in ath11k_update_stats_event() Baochen Qiang
2024-11-13 11:15 ` Kalle Valo
2024-11-13 1:56 ` [PATCH 5/6] wifi: ath11k: move locking outside of ath11k_mac_get_fw_stats() Baochen Qiang
2024-11-13 1:56 ` [PATCH 6/6] wifi: ath11k: consistently use ath11k_mac_get_fw_stats() Baochen Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qtm1236.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_bqiang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).