From: Kalle Valo <kvalo@kernel.org>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Ping-Ke Shih <pkshih@realtek.com>,
Sascha Hauer <sha@pengutronix.de>
Subject: Re: rtw88: alloc_skb(32768, GFP_ATOMIC) fails, driver gets stuck
Date: Wed, 02 Oct 2024 13:58:16 +0300 [thread overview]
Message-ID: <878qv693g7.fsf@kernel.org> (raw)
In-Reply-To: <baca0d5d-072e-4003-ab4a-ecc524d6b89b@gmail.com> (Bitterblue Smith's message of "Mon, 30 Sep 2024 23:56:09 +0300")
Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:
> I still don't know why qBittorrent is required to trigger this bug,
> but I found the problem.
>
> alloc_skb fails (silently) therefore the RX URB is not submitted
> ever again. There are only 4 RX URBs.
Why is alloc_skb() failing silently? Or is that by design? I was under
impression that we should not have error messages for allocation
failures but is that only for kmalloc() & co?
I did a quick look and in wireless drivers some of the alloc_skb()
callers print an error and some fail silently. I think we should start
printing errors for all alloc_skb() calls. Thoughts?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-10-02 10:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 11:46 rtw88: USB devices randomly stop receiving anything Bitterblue Smith
2024-09-26 13:04 ` petter
2024-09-26 16:51 ` Bitterblue Smith
2024-09-27 6:44 ` petter
2024-09-29 11:43 ` Bitterblue Smith
2024-09-30 20:56 ` rtw88: alloc_skb(32768, GFP_ATOMIC) fails, driver gets stuck Bitterblue Smith
2024-10-01 1:25 ` Ping-Ke Shih
2024-10-07 22:03 ` Bitterblue Smith
2024-10-02 10:58 ` Kalle Valo [this message]
2024-10-03 4:26 ` Ping-Ke Shih
2024-10-06 15:43 ` Michał Pecio
2024-10-07 22:04 ` Bitterblue Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qv693g7.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=rtl8821cerfe2@gmail.com \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).