Linux wireless drivers development
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Aaradhana Sahu <quic_aarasahu@quicinc.com>,
	<ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 0/4] ath12k: Factory test mode support
Date: Mon, 30 Oct 2023 19:01:08 +0200	[thread overview]
Message-ID: <878r7kvycr.fsf@kernel.org> (raw)
In-Reply-To: <37452ae3-3006-41ca-9b31-f0d4bed75e35@quicinc.com> (Jeff Johnson's message of "Mon, 30 Oct 2023 08:21:11 -0700")

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 10/30/2023 1:27 AM, Aaradhana Sahu wrote:
>
>> Device is booted in factory test mode for calibration.
>> The commands are sent from userspace application, which
>> is sent to firmware using wmi commands. Firmware sends
>> the response to driver as wmi events and driver sends
>> these events to the application via netlink message.
>> Also added changes related to correct pdev id access for
>> fw test cmd.
>> Aaradhana Sahu (3):
>>    wifi: ath: create common testmode_i.h file for ath drivers
>>    wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode
>>    wifi: ath12k: add factory test mode support
>> Rajat Soni (1):
>>    wifi: ath12k: Fill pdev id for fw test cmd
>>   drivers/net/wireless/ath/ath11k/testmode.c    |  78 ++--
>>   drivers/net/wireless/ath/ath12k/Makefile      |   1 +
>>   drivers/net/wireless/ath/ath12k/core.c        |  19 +-
>>   drivers/net/wireless/ath/ath12k/core.h        |  13 +
>>   drivers/net/wireless/ath/ath12k/debug.h       |   1 +
>>   drivers/net/wireless/ath/ath12k/dp.c          |   3 +
>>   drivers/net/wireless/ath/ath12k/mac.c         |  13 +-
>>   drivers/net/wireless/ath/ath12k/pci.c         |   1 +
>>   drivers/net/wireless/ath/ath12k/testmode.c    | 413 ++++++++++++++++++
>>   drivers/net/wireless/ath/ath12k/testmode.h    |  42 ++
>>   drivers/net/wireless/ath/ath12k/wmi.c         |  38 +-
>>   drivers/net/wireless/ath/ath12k/wmi.h         |  22 +-
>>   .../wireless/ath/{ath11k => }/testmode_i.h    |  52 +--
>>   13 files changed, 624 insertions(+), 72 deletions(-)
>>   create mode 100644 drivers/net/wireless/ath/ath12k/testmode.c
>>   create mode 100644 drivers/net/wireless/ath/ath12k/testmode.h
>>   rename drivers/net/wireless/ath/{ath11k => }/testmode_i.h (53%)
>> base-commit: 0263687f4441d5a5eab8074d56b4693c8f0acf85
>
> That base-commit is pretty old (tag: ath-202309051328) and your series
> fails to apply to current ath-next, please rebase:

That tag is almost two months old! Aaradhana, what an earth are you
testing with?

> Applying: wifi: ath: create common testmode_i.h file for ath drivers
> Applying: wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode
> Applying: wifi: ath12k: add factory test mode support
> Patch failed at 0003 wifi: ath12k: add factory test mode support
>
> In addition, please use

Jeff, did you sent your mail too early? Something seems to be missing in
your mail.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-10-30 17:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-30  8:27 [PATCH 0/4] ath12k: Factory test mode support Aaradhana Sahu
2023-10-30  8:27 ` [PATCH 1/4] wifi: ath: create common testmode_i.h file for ath drivers Aaradhana Sahu
2023-10-30 15:20   ` Jeff Johnson
2023-10-30  8:27 ` [PATCH 2/4] wifi: ath12k: export ath12k_wmi_tlv_hdr for testmode Aaradhana Sahu
2023-10-30  8:27 ` [PATCH 3/4] wifi: ath12k: add factory test mode support Aaradhana Sahu
2023-10-30 17:20   ` Jeff Johnson
2023-10-30  8:27 ` [PATCH 4/4] wifi: ath12k: Fill pdev id for fw test cmd Aaradhana Sahu
2023-10-30 15:21 ` [PATCH 0/4] ath12k: Factory test mode support Jeff Johnson
2023-10-30 17:01   ` Kalle Valo [this message]
2023-10-30 17:11     ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r7kvycr.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_aarasahu@quicinc.com \
    --cc=quic_jjohnson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox