* [PATCH] rtlwifi: rtl8192de: phy: "foo * bar" should be "foo *bar" [not found] <tencent_56B12E143DA8D1D6A9C3669E04C963914905@qq.com> @ 2023-07-19 9:54 ` hanyu001 2023-07-19 13:25 ` Larry Finger 2023-07-24 14:23 ` Kalle Valo 0 siblings, 2 replies; 3+ messages in thread From: hanyu001 @ 2023-07-19 9:54 UTC (permalink / raw) To: pkshih, kvalo; +Cc: linux-wireless, linux-kernel This patch fixes the checkpatch.pl error: ./drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c:2434: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Yu Han <hanyu001@208suo.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c index d18c092..27b029b 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c @@ -2431,7 +2431,7 @@ static bool _rtl92d_is_legal_5g_channel(struct ieee80211_hw *hw, u8 channel) } static void _rtl92d_phy_calc_curvindex(struct ieee80211_hw *hw, - u32 *targetchnl, u32 * curvecount_val, + u32 *targetchnl, u32 *curvecount_val, bool is5g, u32 *curveindex) { struct rtl_priv *rtlpriv = rtl_priv(hw); ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192de: phy: "foo * bar" should be "foo *bar" 2023-07-19 9:54 ` [PATCH] rtlwifi: rtl8192de: phy: "foo * bar" should be "foo *bar" hanyu001 @ 2023-07-19 13:25 ` Larry Finger 2023-07-24 14:23 ` Kalle Valo 1 sibling, 0 replies; 3+ messages in thread From: Larry Finger @ 2023-07-19 13:25 UTC (permalink / raw) To: hanyu001, pkshih, kvalo; +Cc: linux-wireless, linux-kernel On 7/19/23 04:54, hanyu001@208suo.com wrote: > > This patch fixes the checkpatch.pl error: > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c:2434: ERROR: "foo * bar" > should be "foo *bar" > > Signed-off-by: Yu Han <hanyu001@208suo.com> > --- > drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c > b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c > index d18c092..27b029b 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c > @@ -2431,7 +2431,7 @@ static bool _rtl92d_is_legal_5g_channel(struct > ieee80211_hw *hw, u8 channel) > } > > static void _rtl92d_phy_calc_curvindex(struct ieee80211_hw *hw, > - u32 *targetchnl, u32 * curvecount_val, > + u32 *targetchnl, u32 *curvecount_val, > bool is5g, u32 *curveindex) > { > struct rtl_priv *rtlpriv = rtl_priv(hw); The preferred subject would be "wifi: rtlwifi: rtl8192de: ...." That can probably be fixed at merge time. I will let Kalle decide that part. Reviewed-by: Larry Finger<Larry.Finger@lwfinger.net> Thanks, Larry ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192de: phy: "foo * bar" should be "foo *bar" 2023-07-19 9:54 ` [PATCH] rtlwifi: rtl8192de: phy: "foo * bar" should be "foo *bar" hanyu001 2023-07-19 13:25 ` Larry Finger @ 2023-07-24 14:23 ` Kalle Valo 1 sibling, 0 replies; 3+ messages in thread From: Kalle Valo @ 2023-07-24 14:23 UTC (permalink / raw) To: hanyu001; +Cc: pkshih, linux-wireless, linux-kernel hanyu001@208suo.com writes: > This patch fixes the checkpatch.pl error: > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c:2434: ERROR: > "foo * bar" should be "foo *bar" > > Signed-off-by: Yu Han <hanyu001@208suo.com> Please don't submit checkpatch fixes to wireless, they are too much work with very little gain. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-24 14:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <tencent_56B12E143DA8D1D6A9C3669E04C963914905@qq.com>
2023-07-19 9:54 ` [PATCH] rtlwifi: rtl8192de: phy: "foo * bar" should be "foo *bar" hanyu001
2023-07-19 13:25 ` Larry Finger
2023-07-24 14:23 ` Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).