* brcmfmac: Unexpected cfg80211_set_channel: set chanspec ... fail, reason -52
@ 2022-12-30 17:39 Stefan Wahren
2023-01-02 19:23 ` Arend van Spriel
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Wahren @ 2022-12-30 17:39 UTC (permalink / raw)
To: Arend van Spriel, Franky Lin, Hante Meuleman
Cc: linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list
Hi,
since Linux 6.2-rc1 i noticed on my Raspberry Pi 3 B+
(arm/multi_v7_defconfig) the following new error messages appear, even
if there is no Wifi connection. I suspect this is not a real issue, so
it would nice to get the rid of it:
[ 26.303445] brcmfmac: brcmf_fw_alloc_request: using
brcm/brcmfmac43455-sdio for chip BCM4345/6
[ 26.303554] brcmfmac mmc1:0001:1: Direct firmware load for
brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.bin failed with error -2
[ 26.516752] brcmfmac_wcc: brcmf_wcc_attach: executing
[ 26.528264] brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4345/6 wl0:
Jan 4 2021 19:56:29 version 7.45.229 (617f1f5 CY) FWID 01-2dbd9d2e
[ 27.076829] Bluetooth: hci0: BCM: features 0x2f
[ 27.078592] Bluetooth: hci0: BCM43455 37.4MHz Raspberry Pi 3+
[ 27.078601] Bluetooth: hci0: BCM4345C0 (003.001.025) build 0342
[ 30.142104] Adding 102396k swap on /var/swap. Priority:-2 extents:1
across:102396k SS
[ 30.590017] Bluetooth: MGMT ver 1.22
[ 104.897615] brcmfmac: cfg80211_set_channel: set chanspec 0x100e fail,
reason -52
[ 104.897992] brcmfmac: cfg80211_set_channel: set chanspec 0xd022 fail,
reason -52
[ 105.007672] brcmfmac: cfg80211_set_channel: set chanspec 0xd026 fail,
reason -52
[ 105.117654] brcmfmac: cfg80211_set_channel: set chanspec 0xd02a fail,
reason -52
[ 105.227636] brcmfmac: cfg80211_set_channel: set chanspec 0xd02e fail,
reason -52
[ 106.987552] brcmfmac: cfg80211_set_channel: set chanspec 0xd090 fail,
reason -52
[ 106.987911] brcmfmac: cfg80211_set_channel: set chanspec 0xd095 fail,
reason -52
[ 106.988233] brcmfmac: cfg80211_set_channel: set chanspec 0xd099 fail,
reason -52
[ 106.988565] brcmfmac: cfg80211_set_channel: set chanspec 0xd09d fail,
reason -52
[ 106.988909] brcmfmac: cfg80211_set_channel: set chanspec 0xd0a1 fail,
reason -52
All of these 10 errors are repeated every 60 sec.
If i enable the debugging for brcmf_fil_cmd_data, i'm getting this:
[ 107.069199] brcmfmac: Firmware error: BCME_BADCHAN (-20)
[ 107.069232] brcmfmac: cfg80211_set_channel: set chanspec 0x100e fail,
reason -52
[ 107.069597] brcmfmac: Firmware error: BCME_BADCHAN (-20)
[ 107.069610] brcmfmac: cfg80211_set_channel: set chanspec 0xd022 fail,
reason -52
...
Here some additional information:
$ iw info
Interface wlan0
ifindex 4
wdev 0x1
addr b8:27:eb:2e:ec:42
type managed
wiphy 0
channel 140 (5700 MHz), width: 20 MHz, center1: 5700 MHz
txpower 31.00 dBm
$ iw reg get
global
country DE: DFS-ETSI
(2400 - 2483 @ 40), (N/A, 20), (N/A)
(5150 - 5250 @ 80), (N/A, 20), (N/A), NO-OUTDOOR, AUTO-BW
(5250 - 5350 @ 80), (N/A, 20), (0 ms), NO-OUTDOOR, DFS, AUTO-BW
(5470 - 5725 @ 160), (N/A, 26), (0 ms), DFS
(5725 - 5875 @ 80), (N/A, 13), (N/A)
(57000 - 66000 @ 2160), (N/A, 40), (N/A)
phy#0
country 99: DFS-UNSET
(2402 - 2482 @ 40), (6, 20), (N/A)
(2474 - 2494 @ 20), (6, 20), (N/A)
(5140 - 5360 @ 160), (6, 20), (N/A)
(5460 - 5860 @ 160), (6, 20), (N/A)
$ iw list
Wiphy phy0
max # scan SSIDs: 10
max scan IEs length: 2048 bytes
max # sched scan SSIDs: 16
max # match sets: 16
Retry short limit: 7
Retry long limit: 4
Coverage class: 0 (up to 0m)
Device supports roaming.
Device supports T-DLS.
Supported Ciphers:
* WEP40 (00-0f-ac:1)
* WEP104 (00-0f-ac:5)
* TKIP (00-0f-ac:2)
* CCMP-128 (00-0f-ac:4)
* CMAC (00-0f-ac:6)
Available Antennas: TX 0 RX 0
Supported interface modes:
* IBSS
* managed
* AP
* P2P-client
* P2P-GO
* P2P-device
Band 1:
Capabilities: 0x1062
HT20/HT40
Static SM Power Save
RX HT20 SGI
RX HT40 SGI
No RX STBC
Max AMSDU length: 3839 bytes
DSSS/CCK HT40
Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
Minimum RX AMPDU time spacing: 16 usec (0x07)
HT TX/RX MCS rate indexes supported: 0-7
Bitrates (non-HT):
* 1.0 Mbps
* 2.0 Mbps (short preamble supported)
* 5.5 Mbps (short preamble supported)
* 11.0 Mbps (short preamble supported)
* 6.0 Mbps
* 9.0 Mbps
* 12.0 Mbps
* 18.0 Mbps
* 24.0 Mbps
* 36.0 Mbps
* 48.0 Mbps
* 54.0 Mbps
Frequencies:
* 2412 MHz [1] (20.0 dBm)
* 2417 MHz [2] (20.0 dBm)
* 2422 MHz [3] (20.0 dBm)
* 2427 MHz [4] (20.0 dBm)
* 2432 MHz [5] (20.0 dBm)
* 2437 MHz [6] (20.0 dBm)
* 2442 MHz [7] (20.0 dBm)
* 2447 MHz [8] (20.0 dBm)
* 2452 MHz [9] (20.0 dBm)
* 2457 MHz [10] (20.0 dBm)
* 2462 MHz [11] (20.0 dBm)
* 2467 MHz [12] (20.0 dBm)
* 2472 MHz [13] (20.0 dBm)
* 2484 MHz [14] (disabled)
Band 2:
Capabilities: 0x1062
HT20/HT40
Static SM Power Save
RX HT20 SGI
RX HT40 SGI
No RX STBC
Max AMSDU length: 3839 bytes
DSSS/CCK HT40
Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
Minimum RX AMPDU time spacing: 16 usec (0x07)
HT TX/RX MCS rate indexes supported: 0-7
VHT Capabilities (0x00001020):
Max MPDU length: 3895
Supported Channel Width: neither 160 nor 80+80
short GI (80 MHz)
SU Beamformee
VHT RX MCS set:
1 streams: MCS 0-9
2 streams: not supported
3 streams: not supported
4 streams: not supported
5 streams: not supported
6 streams: not supported
7 streams: not supported
8 streams: not supported
VHT RX highest supported: 0 Mbps
VHT TX MCS set:
1 streams: MCS 0-9
2 streams: not supported
3 streams: not supported
4 streams: not supported
5 streams: not supported
6 streams: not supported
7 streams: not supported
8 streams: not supported
VHT TX highest supported: 0 Mbps
Bitrates (non-HT):
* 6.0 Mbps
* 9.0 Mbps
* 12.0 Mbps
* 18.0 Mbps
* 24.0 Mbps
* 36.0 Mbps
* 48.0 Mbps
* 54.0 Mbps
Frequencies:
* 5170 MHz [34] (disabled)
* 5180 MHz [36] (20.0 dBm)
* 5190 MHz [38] (disabled)
* 5200 MHz [40] (20.0 dBm)
* 5210 MHz [42] (disabled)
* 5220 MHz [44] (20.0 dBm)
* 5230 MHz [46] (disabled)
* 5240 MHz [48] (20.0 dBm)
* 5260 MHz [52] (20.0 dBm) (no IR, radar detection)
* 5280 MHz [56] (20.0 dBm) (no IR, radar detection)
* 5300 MHz [60] (20.0 dBm) (no IR, radar detection)
* 5320 MHz [64] (20.0 dBm) (no IR, radar detection)
* 5500 MHz [100] (20.0 dBm) (no IR, radar detection)
* 5520 MHz [104] (20.0 dBm) (no IR, radar detection)
* 5540 MHz [108] (20.0 dBm) (no IR, radar detection)
* 5560 MHz [112] (20.0 dBm) (no IR, radar detection)
* 5580 MHz [116] (20.0 dBm) (no IR, radar detection)
* 5600 MHz [120] (20.0 dBm) (no IR, radar detection)
* 5620 MHz [124] (20.0 dBm) (no IR, radar detection)
* 5640 MHz [128] (20.0 dBm) (no IR, radar detection)
* 5660 MHz [132] (20.0 dBm) (no IR, radar detection)
* 5680 MHz [136] (20.0 dBm) (no IR, radar detection)
* 5700 MHz [140] (20.0 dBm) (no IR, radar detection)
* 5720 MHz [144] (disabled)
* 5745 MHz [149] (disabled)
* 5765 MHz [153] (disabled)
* 5785 MHz [157] (disabled)
* 5805 MHz [161] (disabled)
* 5825 MHz [165] (disabled)
Supported commands:
* new_interface
* set_interface
* new_key
* start_ap
* join_ibss
* set_pmksa
* del_pmksa
* flush_pmksa
* remain_on_channel
* frame
* set_wiphy_netns
* set_channel
* tdls_oper
* start_sched_scan
* start_p2p_device
* connect
* disconnect
* crit_protocol_start
* crit_protocol_stop
* update_connect_params
software interface modes (can always be added):
valid interface combinations:
* #{ managed } <= 2, #{ P2P-device } <= 1, #{ P2P-client,
P2P-GO } <= 1,
total <= 3, #channels <= 2
* #{ managed } <= 1, #{ AP } <= 1, #{ P2P-client } <= 1, #{
P2P-device } <= 1,
total <= 4, #channels <= 1
Device supports scan flush.
Device supports randomizing MAC-addr in sched scans.
max # scan plans: 1
max scan plan interval: 508
max scan plan iterations: 0
Supported TX frame types:
* managed: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90
0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* AP: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0
0xb0 0xc0 0xd0 0xe0 0xf0
* P2P-client: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80
0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* P2P-GO: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90
0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
* P2P-device: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80
0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
Supported RX frame types:
* managed: 0x40 0xd0
* AP: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
* P2P-client: 0x40 0xd0
* P2P-GO: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
* P2P-device: 0x40 0xd0
Supported extended features:
* [ CQM_RSSI_LIST ]: multiple CQM_RSSI_THOLD records
* [ 4WAY_HANDSHAKE_STA_PSK ]: 4-way handshake with PSK in
station mode
* [ 4WAY_HANDSHAKE_STA_1X ]: 4-way handshake with 802.1X in
station mode
* [ DFS_OFFLOAD ]: DFS offload
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: brcmfmac: Unexpected cfg80211_set_channel: set chanspec ... fail, reason -52
2022-12-30 17:39 brcmfmac: Unexpected cfg80211_set_channel: set chanspec ... fail, reason -52 Stefan Wahren
@ 2023-01-02 19:23 ` Arend van Spriel
2023-01-03 7:07 ` Johannes Berg
0 siblings, 1 reply; 8+ messages in thread
From: Arend van Spriel @ 2023-01-02 19:23 UTC (permalink / raw)
To: Stefan Wahren, Arend van Spriel, Franky Lin, Hante Meuleman,
Johannes Berg
Cc: linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list
[-- Attachment #1: Type: text/plain, Size: 12897 bytes --]
+ Johannes
On 12/30/2022 6:39 PM, Stefan Wahren wrote:
> Hi,
>
> since Linux 6.2-rc1 i noticed on my Raspberry Pi 3 B+
> (arm/multi_v7_defconfig) the following new error messages appear, even
> if there is no Wifi connection. I suspect this is not a real issue, so
> it would nice to get the rid of it:
>
> [ 26.303445] brcmfmac: brcmf_fw_alloc_request: using
> brcm/brcmfmac43455-sdio for chip BCM4345/6
> [ 26.303554] brcmfmac mmc1:0001:1: Direct firmware load for
> brcm/brcmfmac43455-sdio.raspberrypi,3-model-b-plus.bin failed with error -2
> [ 26.516752] brcmfmac_wcc: brcmf_wcc_attach: executing
> [ 26.528264] brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4345/6 wl0:
> Jan 4 2021 19:56:29 version 7.45.229 (617f1f5 CY) FWID 01-2dbd9d2e
> [ 27.076829] Bluetooth: hci0: BCM: features 0x2f
> [ 27.078592] Bluetooth: hci0: BCM43455 37.4MHz Raspberry Pi 3+
> [ 27.078601] Bluetooth: hci0: BCM4345C0 (003.001.025) build 0342
> [ 30.142104] Adding 102396k swap on /var/swap. Priority:-2 extents:1
> across:102396k SS
> [ 30.590017] Bluetooth: MGMT ver 1.22
> [ 104.897615] brcmfmac: cfg80211_set_channel: set chanspec 0x100e fail,
> reason -52
> [ 104.897992] brcmfmac: cfg80211_set_channel: set chanspec 0xd022 fail,
> reason -52
> [ 105.007672] brcmfmac: cfg80211_set_channel: set chanspec 0xd026 fail,
> reason -52
> [ 105.117654] brcmfmac: cfg80211_set_channel: set chanspec 0xd02a fail,
> reason -52
> [ 105.227636] brcmfmac: cfg80211_set_channel: set chanspec 0xd02e fail,
> reason -52
> [ 106.987552] brcmfmac: cfg80211_set_channel: set chanspec 0xd090 fail,
> reason -52
> [ 106.987911] brcmfmac: cfg80211_set_channel: set chanspec 0xd095 fail,
> reason -52
> [ 106.988233] brcmfmac: cfg80211_set_channel: set chanspec 0xd099 fail,
> reason -52
> [ 106.988565] brcmfmac: cfg80211_set_channel: set chanspec 0xd09d fail,
> reason -52
> [ 106.988909] brcmfmac: cfg80211_set_channel: set chanspec 0xd0a1 fail,
> reason -52
>
> All of these 10 errors are repeated every 60 sec.
Catching up after the holidays ;-) Above chanspec values are invalid.
0x100e = channel 14/bw 20MHz. The 'iw list' output shows all these
channels are disabled. So who/what is trying to set these channels.
Scanning sets the channel in firmware. Is this initiated from hostapd?
Maybe trying ACS? As these are marked as disabled user-space should not
use them. What I don't understand is why these pass the cfg80211 layer
so adding Johannes here.
Regards,
Arend
> If i enable the debugging for brcmf_fil_cmd_data, i'm getting this:
>
> [ 107.069199] brcmfmac: Firmware error: BCME_BADCHAN (-20)
> [ 107.069232] brcmfmac: cfg80211_set_channel: set chanspec 0x100e fail,
> reason -52
> [ 107.069597] brcmfmac: Firmware error: BCME_BADCHAN (-20)
> [ 107.069610] brcmfmac: cfg80211_set_channel: set chanspec 0xd022 fail,
> reason -52
> ...
>
> Here some additional information:
>
> $ iw info
>
> Interface wlan0
> ifindex 4
> wdev 0x1
> addr b8:27:eb:2e:ec:42
> type managed
> wiphy 0
> channel 140 (5700 MHz), width: 20 MHz, center1: 5700 MHz
> txpower 31.00 dBm
>
> $ iw reg get
>
> global
> country DE: DFS-ETSI
> (2400 - 2483 @ 40), (N/A, 20), (N/A)
> (5150 - 5250 @ 80), (N/A, 20), (N/A), NO-OUTDOOR, AUTO-BW
> (5250 - 5350 @ 80), (N/A, 20), (0 ms), NO-OUTDOOR, DFS, AUTO-BW
> (5470 - 5725 @ 160), (N/A, 26), (0 ms), DFS
> (5725 - 5875 @ 80), (N/A, 13), (N/A)
> (57000 - 66000 @ 2160), (N/A, 40), (N/A)
>
> phy#0
> country 99: DFS-UNSET
> (2402 - 2482 @ 40), (6, 20), (N/A)
> (2474 - 2494 @ 20), (6, 20), (N/A)
> (5140 - 5360 @ 160), (6, 20), (N/A)
> (5460 - 5860 @ 160), (6, 20), (N/A)
>
> $ iw list
>
> Wiphy phy0
> max # scan SSIDs: 10
> max scan IEs length: 2048 bytes
> max # sched scan SSIDs: 16
> max # match sets: 16
> Retry short limit: 7
> Retry long limit: 4
> Coverage class: 0 (up to 0m)
> Device supports roaming.
> Device supports T-DLS.
> Supported Ciphers:
> * WEP40 (00-0f-ac:1)
> * WEP104 (00-0f-ac:5)
> * TKIP (00-0f-ac:2)
> * CCMP-128 (00-0f-ac:4)
> * CMAC (00-0f-ac:6)
> Available Antennas: TX 0 RX 0
> Supported interface modes:
> * IBSS
> * managed
> * AP
> * P2P-client
> * P2P-GO
> * P2P-device
> Band 1:
> Capabilities: 0x1062
> HT20/HT40
> Static SM Power Save
> RX HT20 SGI
> RX HT40 SGI
> No RX STBC
> Max AMSDU length: 3839 bytes
> DSSS/CCK HT40
> Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
> Minimum RX AMPDU time spacing: 16 usec (0x07)
> HT TX/RX MCS rate indexes supported: 0-7
> Bitrates (non-HT):
> * 1.0 Mbps
> * 2.0 Mbps (short preamble supported)
> * 5.5 Mbps (short preamble supported)
> * 11.0 Mbps (short preamble supported)
> * 6.0 Mbps
> * 9.0 Mbps
> * 12.0 Mbps
> * 18.0 Mbps
> * 24.0 Mbps
> * 36.0 Mbps
> * 48.0 Mbps
> * 54.0 Mbps
> Frequencies:
> * 2412 MHz [1] (20.0 dBm)
> * 2417 MHz [2] (20.0 dBm)
> * 2422 MHz [3] (20.0 dBm)
> * 2427 MHz [4] (20.0 dBm)
> * 2432 MHz [5] (20.0 dBm)
> * 2437 MHz [6] (20.0 dBm)
> * 2442 MHz [7] (20.0 dBm)
> * 2447 MHz [8] (20.0 dBm)
> * 2452 MHz [9] (20.0 dBm)
> * 2457 MHz [10] (20.0 dBm)
> * 2462 MHz [11] (20.0 dBm)
> * 2467 MHz [12] (20.0 dBm)
> * 2472 MHz [13] (20.0 dBm)
> * 2484 MHz [14] (disabled)
> Band 2:
> Capabilities: 0x1062
> HT20/HT40
> Static SM Power Save
> RX HT20 SGI
> RX HT40 SGI
> No RX STBC
> Max AMSDU length: 3839 bytes
> DSSS/CCK HT40
> Maximum RX AMPDU length 65535 bytes (exponent: 0x003)
> Minimum RX AMPDU time spacing: 16 usec (0x07)
> HT TX/RX MCS rate indexes supported: 0-7
> VHT Capabilities (0x00001020):
> Max MPDU length: 3895
> Supported Channel Width: neither 160 nor 80+80
> short GI (80 MHz)
> SU Beamformee
> VHT RX MCS set:
> 1 streams: MCS 0-9
> 2 streams: not supported
> 3 streams: not supported
> 4 streams: not supported
> 5 streams: not supported
> 6 streams: not supported
> 7 streams: not supported
> 8 streams: not supported
> VHT RX highest supported: 0 Mbps
> VHT TX MCS set:
> 1 streams: MCS 0-9
> 2 streams: not supported
> 3 streams: not supported
> 4 streams: not supported
> 5 streams: not supported
> 6 streams: not supported
> 7 streams: not supported
> 8 streams: not supported
> VHT TX highest supported: 0 Mbps
> Bitrates (non-HT):
> * 6.0 Mbps
> * 9.0 Mbps
> * 12.0 Mbps
> * 18.0 Mbps
> * 24.0 Mbps
> * 36.0 Mbps
> * 48.0 Mbps
> * 54.0 Mbps
> Frequencies:
> * 5170 MHz [34] (disabled)
> * 5180 MHz [36] (20.0 dBm)
> * 5190 MHz [38] (disabled)
> * 5200 MHz [40] (20.0 dBm)
> * 5210 MHz [42] (disabled)
> * 5220 MHz [44] (20.0 dBm)
> * 5230 MHz [46] (disabled)
> * 5240 MHz [48] (20.0 dBm)
> * 5260 MHz [52] (20.0 dBm) (no IR, radar detection)
> * 5280 MHz [56] (20.0 dBm) (no IR, radar detection)
> * 5300 MHz [60] (20.0 dBm) (no IR, radar detection)
> * 5320 MHz [64] (20.0 dBm) (no IR, radar detection)
> * 5500 MHz [100] (20.0 dBm) (no IR, radar detection)
> * 5520 MHz [104] (20.0 dBm) (no IR, radar detection)
> * 5540 MHz [108] (20.0 dBm) (no IR, radar detection)
> * 5560 MHz [112] (20.0 dBm) (no IR, radar detection)
> * 5580 MHz [116] (20.0 dBm) (no IR, radar detection)
> * 5600 MHz [120] (20.0 dBm) (no IR, radar detection)
> * 5620 MHz [124] (20.0 dBm) (no IR, radar detection)
> * 5640 MHz [128] (20.0 dBm) (no IR, radar detection)
> * 5660 MHz [132] (20.0 dBm) (no IR, radar detection)
> * 5680 MHz [136] (20.0 dBm) (no IR, radar detection)
> * 5700 MHz [140] (20.0 dBm) (no IR, radar detection)
> * 5720 MHz [144] (disabled)
> * 5745 MHz [149] (disabled)
> * 5765 MHz [153] (disabled)
> * 5785 MHz [157] (disabled)
> * 5805 MHz [161] (disabled)
> * 5825 MHz [165] (disabled)
> Supported commands:
> * new_interface
> * set_interface
> * new_key
> * start_ap
> * join_ibss
> * set_pmksa
> * del_pmksa
> * flush_pmksa
> * remain_on_channel
> * frame
> * set_wiphy_netns
> * set_channel
> * tdls_oper
> * start_sched_scan
> * start_p2p_device
> * connect
> * disconnect
> * crit_protocol_start
> * crit_protocol_stop
> * update_connect_params
> software interface modes (can always be added):
> valid interface combinations:
> * #{ managed } <= 2, #{ P2P-device } <= 1, #{ P2P-client,
> P2P-GO } <= 1,
> total <= 3, #channels <= 2
> * #{ managed } <= 1, #{ AP } <= 1, #{ P2P-client } <= 1, #{
> P2P-device } <= 1,
> total <= 4, #channels <= 1
> Device supports scan flush.
> Device supports randomizing MAC-addr in sched scans.
> max # scan plans: 1
> max scan plan interval: 508
> max scan plan iterations: 0
> Supported TX frame types:
> * managed: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90
> 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
> * AP: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90 0xa0
> 0xb0 0xc0 0xd0 0xe0 0xf0
> * P2P-client: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80
> 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
> * P2P-GO: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80 0x90
> 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
> * P2P-device: 0x00 0x10 0x20 0x30 0x40 0x50 0x60 0x70 0x80
> 0x90 0xa0 0xb0 0xc0 0xd0 0xe0 0xf0
> Supported RX frame types:
> * managed: 0x40 0xd0
> * AP: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
> * P2P-client: 0x40 0xd0
> * P2P-GO: 0x00 0x20 0x40 0xa0 0xb0 0xc0 0xd0
> * P2P-device: 0x40 0xd0
> Supported extended features:
> * [ CQM_RSSI_LIST ]: multiple CQM_RSSI_THOLD records
> * [ 4WAY_HANDSHAKE_STA_PSK ]: 4-way handshake with PSK in
> station mode
> * [ 4WAY_HANDSHAKE_STA_1X ]: 4-way handshake with 802.1X in
> station mode
> * [ DFS_OFFLOAD ]: DFS offload
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: brcmfmac: Unexpected cfg80211_set_channel: set chanspec ... fail, reason -52
2023-01-02 19:23 ` Arend van Spriel
@ 2023-01-03 7:07 ` Johannes Berg
2023-01-03 9:57 ` Arend van Spriel
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Johannes Berg @ 2023-01-03 7:07 UTC (permalink / raw)
To: Arend van Spriel, Stefan Wahren, Arend van Spriel, Franky Lin,
Hante Meuleman
Cc: linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list
Hi,
> > [ 104.897615] brcmfmac: cfg80211_set_channel: set chanspec 0x100e fail,
> > reason -52
[...]
>
> > All of these 10 errors are repeated every 60 sec.
>
> Catching up after the holidays ;-) Above chanspec values are invalid.
> 0x100e = channel 14/bw 20MHz. The 'iw list' output shows all these
> channels are disabled. So who/what is trying to set these channels.
> Scanning sets the channel in firmware. Is this initiated from hostapd?
Yeah, what userspace is running here? Looks like cfg80211_set_channel()
is only used for survey?
Couple of observations on the side:
* might be nice to have some "brcm" indication in that name :P
* dump_survey should just dump data, not actually implement the data
collection, I think?
> Maybe trying ACS?
>
Seems it must be something like that.
> As these are marked as disabled user-space should not
> use them. What I don't understand is why these pass the cfg80211 layer
> so adding Johannes here.
>
Well that goes back to my earlier observation above: dump_survey()
should just dump all *available* data, not actually try to *collect*
data. So if userspace requests data for a channel that's disabled,
that's actually OK, but you shouldn't _have_ any data for that channel
since it's disabled. Also nl80211 won't send the data out if it exists,
but there's no check to see if asking the driver makes sense since if
it's a channel that exists, it should be valid to ask the driver if it
has data - it just shouldn't have any.
The way it works in mac80211 is that survey data is collected during
scan, I think?
johannes
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: brcmfmac: Unexpected cfg80211_set_channel: set chanspec ... fail, reason -52
2023-01-03 7:07 ` Johannes Berg
@ 2023-01-03 9:57 ` Arend van Spriel
2023-01-03 11:46 ` Stefan Wahren
2023-01-13 13:35 ` Kalle Valo
2 siblings, 0 replies; 8+ messages in thread
From: Arend van Spriel @ 2023-01-03 9:57 UTC (permalink / raw)
To: Johannes Berg, Stefan Wahren, Arend van Spriel, Franky Lin,
Hante Meuleman
Cc: linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list
[-- Attachment #1: Type: text/plain, Size: 3158 bytes --]
On 1/3/2023 8:07 AM, Johannes Berg wrote:
> Hi,
>
>
>>> [ 104.897615] brcmfmac: cfg80211_set_channel: set chanspec 0x100e fail,
>>> reason -52
>
> [...]
>
>>
>>> All of these 10 errors are repeated every 60 sec.
>>
>> Catching up after the holidays ;-) Above chanspec values are invalid.
>> 0x100e = channel 14/bw 20MHz. The 'iw list' output shows all these
>> channels are disabled. So who/what is trying to set these channels.
>> Scanning sets the channel in firmware. Is this initiated from hostapd?
>
> Yeah, what userspace is running here? Looks like cfg80211_set_channel()
> is only used for survey?
>
> Couple of observations on the side:
> * might be nice to have some "brcm" indication in that name :P
> * dump_survey should just dump data, not actually implement the data
> collection, I think?
commit 6c04deae1438e5df59fc4848795248fc34961f51
Author: Wright Feng <wright.feng@cypress.com>
Commit: Kalle Valo <kvalo@kernel.org>
brcmfmac: Add dump_survey cfg80211 ops for HostApd AutoChannelSelection
To enable ACS feature in Hostap daemon, dump_survey cfg80211 ops
and dump
obss survey command in firmware side are needed. This patch is for
adding
dump_survey feature and adding DUMP_OBSS feature flag to check if
firmware supports dump_obss iovar.
Signed-off-by: Wright Feng <wright.feng@cypress.com>
Signed-off-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>
Signed-off-by: Ian Lin <ian.lin@infineon.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link:
https://lore.kernel.org/r/20220929012527.4152-2-ian.lin@infineon.com
I did comment on one of the patches in the series, but I now I looked at
the diff and it is giving me the infamous eyeball cancer paraphrasing
John Linville.
>> Maybe trying ACS?
>>
>
> Seems it must be something like that.
>
>> As these are marked as disabled user-space should not
>> use them. What I don't understand is why these pass the cfg80211 layer
>> so adding Johannes here.
>>
>
> Well that goes back to my earlier observation above: dump_survey()
> should just dump all *available* data, not actually try to *collect*
> data. So if userspace requests data for a channel that's disabled,
> that's actually OK, but you shouldn't _have_ any data for that channel
> since it's disabled. Also nl80211 won't send the data out if it exists,
> but there's no check to see if asking the driver makes sense since if
> it's a channel that exists, it should be valid to ask the driver if it
> has data - it just shouldn't have any.
>
> The way it works in mac80211 is that survey data is collected during
> scan, I think?
My assumption is that our scan does not collect the survey data so this
implementation initiates a dedicated scan/measurement/survey/whatever
and returns the results. Might have been better to propose a scan flag
so this could be initiated upon a scan request.
Anyway, I see in nl80211.c we are skipping sending up survey data for
disable channels. So let me send a quick patch for avoiding the error
messages and renaming the function. Thanks for your thought. Always
appreciated. Best wishes for 2023.
Gr. AvS
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: brcmfmac: Unexpected cfg80211_set_channel: set chanspec ... fail, reason -52
2023-01-03 7:07 ` Johannes Berg
2023-01-03 9:57 ` Arend van Spriel
@ 2023-01-03 11:46 ` Stefan Wahren
2023-01-13 13:35 ` Kalle Valo
2 siblings, 0 replies; 8+ messages in thread
From: Stefan Wahren @ 2023-01-03 11:46 UTC (permalink / raw)
To: Johannes Berg, Arend van Spriel, Arend van Spriel, Franky Lin,
Hante Meuleman
Cc: linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list
Hi,
Am 03.01.23 um 08:07 schrieb Johannes Berg:
> Hi,
>
>
>>> [ 104.897615] brcmfmac: cfg80211_set_channel: set chanspec 0x100e fail,
>>> reason -52
> [...]
>
>>> All of these 10 errors are repeated every 60 sec.
>> Catching up after the holidays ;-) Above chanspec values are invalid.
>> 0x100e = channel 14/bw 20MHz. The 'iw list' output shows all these
>> channels are disabled. So who/what is trying to set these channels.
>> Scanning sets the channel in firmware. Is this initiated from hostapd?
> Yeah, what userspace is running here?
i'm using Raspberry Pi OS. It's a debian based distribution optimized
for Raspberry Pi. I suspect this comes from a lxpanel widget which
allows to select a SSID from available wifi networks. ps commands also
shows a running wpa_supplicant.
> Looks like cfg80211_set_channel()
> is only used for survey?
>
> Couple of observations on the side:
> * might be nice to have some "brcm" indication in that name :P
> * dump_survey should just dump data, not actually implement the data
> collection, I think?
>
>
>> Maybe trying ACS?
>>
> Seems it must be something like that.
>
>> As these are marked as disabled user-space should not
>> use them. What I don't understand is why these pass the cfg80211 layer
>> so adding Johannes here.
>>
> Well that goes back to my earlier observation above: dump_survey()
> should just dump all *available* data, not actually try to *collect*
> data. So if userspace requests data for a channel that's disabled,
> that's actually OK, but you shouldn't _have_ any data for that channel
> since it's disabled. Also nl80211 won't send the data out if it exists,
> but there's no check to see if asking the driver makes sense since if
> it's a channel that exists, it should be valid to ask the driver if it
> has data - it just shouldn't have any.
>
> The way it works in mac80211 is that survey data is collected during
> scan, I think?
>
> johannes
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: brcmfmac: Unexpected cfg80211_set_channel: set chanspec ... fail, reason -52
2023-01-03 7:07 ` Johannes Berg
2023-01-03 9:57 ` Arend van Spriel
2023-01-03 11:46 ` Stefan Wahren
@ 2023-01-13 13:35 ` Kalle Valo
2023-01-13 15:14 ` Arend Van Spriel
2 siblings, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2023-01-13 13:35 UTC (permalink / raw)
To: Johannes Berg
Cc: Arend van Spriel, Stefan Wahren, Arend van Spriel, Franky Lin,
Hante Meuleman, linux-wireless, brcm80211-dev-list.pdl,
SHA-cyfmac-dev-list
Johannes Berg <johannes@sipsolutions.net> writes:
>> > [ 104.897615] brcmfmac: cfg80211_set_channel: set chanspec 0x100e fail,
>> > reason -52
>
> [...]
>
>>
>> > All of these 10 errors are repeated every 60 sec.
>>
>> Catching up after the holidays ;-) Above chanspec values are invalid.
>> 0x100e = channel 14/bw 20MHz. The 'iw list' output shows all these
>> channels are disabled. So who/what is trying to set these channels.
>> Scanning sets the channel in firmware. Is this initiated from hostapd?
>
> Yeah, what userspace is running here? Looks like cfg80211_set_channel()
> is only used for survey?
>
> Couple of observations on the side:
> * might be nice to have some "brcm" indication in that name :P
Indeed, having a function cfg80211_set_channel() in brcmfmac/cfg80211.c
is VERY misleading. I first though that is a cfg80211 function and
didn't understand Johannes' comment until I started grepping :) Can
someone fix that, please?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: brcmfmac: Unexpected cfg80211_set_channel: set chanspec ... fail, reason -52
2023-01-13 13:35 ` Kalle Valo
@ 2023-01-13 15:14 ` Arend Van Spriel
2023-01-13 15:54 ` Kalle Valo
0 siblings, 1 reply; 8+ messages in thread
From: Arend Van Spriel @ 2023-01-13 15:14 UTC (permalink / raw)
To: Kalle Valo, Johannes Berg
Cc: Stefan Wahren, Arend van Spriel, Franky Lin, Hante Meuleman,
linux-wireless, brcm80211-dev-list.pdl, SHA-cyfmac-dev-list
[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]
On January 13, 2023 2:35:58 PM Kalle Valo <kvalo@kernel.org> wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
>>>> [ 104.897615] brcmfmac: cfg80211_set_channel: set chanspec 0x100e fail,
>>>> reason -52
>>
>> [...]
>>
>>>
>>>> All of these 10 errors are repeated every 60 sec.
>>>
>>> Catching up after the holidays ;-) Above chanspec values are invalid.
>>> 0x100e = channel 14/bw 20MHz. The 'iw list' output shows all these
>>> channels are disabled. So who/what is trying to set these channels.
>>> Scanning sets the channel in firmware. Is this initiated from hostapd?
>>
>> Yeah, what userspace is running here? Looks like cfg80211_set_channel()
>> is only used for survey?
>>
>> Couple of observations on the side:
>> * might be nice to have some "brcm" indication in that name :P
>
> Indeed, having a function cfg80211_set_channel() in brcmfmac/cfg80211.c
> is VERY misleading. I first though that is a cfg80211 function and
> didn't understand Johannes' comment until I started grepping :) Can
> someone fix that, please?
It is already on your queue for wireless-next. That was the 3rd patch for
which you sent yourself a reminder earlier this week. You remember? ;-p
Gr. AvS
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: brcmfmac: Unexpected cfg80211_set_channel: set chanspec ... fail, reason -52
2023-01-13 15:14 ` Arend Van Spriel
@ 2023-01-13 15:54 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2023-01-13 15:54 UTC (permalink / raw)
To: Arend Van Spriel
Cc: Johannes Berg, Stefan Wahren, Arend van Spriel, Franky Lin,
Hante Meuleman, linux-wireless, brcm80211-dev-list.pdl,
SHA-cyfmac-dev-list
Arend Van Spriel <arend.vanspriel@broadcom.com> writes:
> On January 13, 2023 2:35:58 PM Kalle Valo <kvalo@kernel.org> wrote:
>
>> Johannes Berg <johannes@sipsolutions.net> writes:
>>
>>>>> [ 104.897615] brcmfmac: cfg80211_set_channel: set chanspec 0x100e fail,
>>>>> reason -52
>>>
>>> [...]
>>>
>>>>
>>>>> All of these 10 errors are repeated every 60 sec.
>>>>
>>>> Catching up after the holidays ;-) Above chanspec values are invalid.
>>>> 0x100e = channel 14/bw 20MHz. The 'iw list' output shows all these
>>>> channels are disabled. So who/what is trying to set these channels.
>>>> Scanning sets the channel in firmware. Is this initiated from hostapd?
>>>
>>> Yeah, what userspace is running here? Looks like cfg80211_set_channel()
>>> is only used for survey?
>>>
>>> Couple of observations on the side:
>>> * might be nice to have some "brcm" indication in that name :P
>>
>> Indeed, having a function cfg80211_set_channel() in brcmfmac/cfg80211.c
>> is VERY misleading. I first though that is a cfg80211 function and
>> didn't understand Johannes' comment until I started grepping :) Can
>> someone fix that, please?
>
> It is already on your queue for wireless-next. That was the 3rd patch
> for which you sent yourself a reminder earlier this week. You
> remember? ;-p
Heh. No, I don't even try to remember all the patches, there's just too
much of them :)
But very good that the fix is in queue, thanks!
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-01-13 16:05 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-30 17:39 brcmfmac: Unexpected cfg80211_set_channel: set chanspec ... fail, reason -52 Stefan Wahren
2023-01-02 19:23 ` Arend van Spriel
2023-01-03 7:07 ` Johannes Berg
2023-01-03 9:57 ` Arend van Spriel
2023-01-03 11:46 ` Stefan Wahren
2023-01-13 13:35 ` Kalle Valo
2023-01-13 15:14 ` Arend Van Spriel
2023-01-13 15:54 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).