From: Kalle Valo <kvalo@codeaurora.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: nbd@nbd.name, lorenzo.bianconi@redhat.com,
linux-wireless@vger.kernel.org, Sean.Wang@mediatek.com
Subject: Re: [PATCH v2 01/18] mt76: mt76u: check tx_status_data pointer in mt76u_tx_tasklet
Date: Tue, 14 Jan 2020 16:39:36 +0200 [thread overview]
Message-ID: <878smap0ev.fsf@codeaurora.org> (raw)
In-Reply-To: <20200114143131.GA29696@localhost.localdomain> (Lorenzo Bianconi's message of "Tue, 14 Jan 2020 15:31:31 +0100")
Lorenzo Bianconi <lorenzo@kernel.org> writes:
> On Jan 14, Kalle Valo wrote:
>> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>>
>> > New devices (e.g. mt7663u) do not rely on stats workqueue to load tx
>> > statistics but will be reported by the firmware. Check tx_status_data
>> > pointer in mt76u_tx_tasklet in order to reuse tx tasklet for new devices
>> >
>> > Signed-off-by: Sean Wang <sean.wang@mediatek.com>
>> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>>
>> Why is Sean's s-o-b first? Lorenzo is marked as the author so his s-o-b
>> should be first.
>
> Hi Kalle,
>
> my bad, I did not pay attention on it, I should put my SoB first.
>
>>
>> Also I recommend taking a look at the new Co-Developed-by tag.
>
> I think Co-Developed-by fits better.
Do note that you still need s-o-b as well:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
> @Felix and Kalle: do you prefer to resubmit?
I prefer to resubmit, but not a strong requirement and don't know if
Felix already applied this.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-01-14 14:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 12:21 [PATCH v2 00/18] rework mt76u layer to support new devices Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 01/18] mt76: mt76u: check tx_status_data pointer in mt76u_tx_tasklet Lorenzo Bianconi
2020-01-14 14:14 ` Kalle Valo
2020-01-14 14:31 ` Lorenzo Bianconi
2020-01-14 14:39 ` Kalle Valo [this message]
2020-01-05 12:21 ` [PATCH v2 02/18] mt76: mt76u: add mt76u_process_rx_queue utility routine Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 03/18] mt76: mt76u: add mt76_queue to mt76u_get_next_rx_entry signature Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 04/18] mt76: mt76u: add mt76_queue to mt76u_refill_rx signature Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 05/18] mt76: mt76u: use mt76_queue as mt76u_complete_rx context Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 06/18] mt76: mt76u: add queue id parameter to mt76u_submit_rx_buffers Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 07/18] mt76: mt76u: move mcu buffer allocation in mt76x02u drivers Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 08/18] mt76: mt76u: introduce mt76u_free_rx_queue utility routine Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 09/18] mt76: mt76u: stop/free all possible rx queues Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 10/18] mt76: mt76u: add mt76u_alloc_rx_queue utility routine Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 11/18] mt76: mt76u: add queue parameter to mt76u_rx_urb_alloc Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 12/18] mt76: mt76u: resume all rx queue in mt76u_resume_rx Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 13/18] mt76: mt76u: introduce mt76u_alloc_mcu_queue utility routine Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 14/18] mt76: mt76u: add {read/write}_extended utility routines Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 15/18] mt76: mt76u: take into account different queue mapping for 7663 Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 16/18] mt76: mt76u: introduce mt76u_skb_dma_info routine Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 17/18] mt76: mt76u: add endpoint to mt76u_bulk_msg signature Lorenzo Bianconi
2020-01-05 12:21 ` [PATCH v2 18/18] mt76: mt76u: introduce MT_DRV_RX_DMA_HDR flag Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878smap0ev.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Sean.Wang@mediatek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).