* fq_init() allocation
@ 2019-11-05 14:57 Johannes Berg
2019-11-05 15:44 ` Toke Høiland-Jørgensen
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2019-11-05 14:57 UTC (permalink / raw)
To: Toke Høiland-Jørgensen; +Cc: linux-wireless
Hi,
fq_init() in mac80211 allocates something like 1/2 MB of memory in a
kmalloc() call and I see it failing frequently in our automation now ...
Could we move that to vmalloc()?
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: fq_init() allocation
2019-11-05 14:57 fq_init() allocation Johannes Berg
@ 2019-11-05 15:44 ` Toke Høiland-Jørgensen
0 siblings, 0 replies; 2+ messages in thread
From: Toke Høiland-Jørgensen @ 2019-11-05 15:44 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
Johannes Berg <johannes@sipsolutions.net> writes:
> Hi,
>
> fq_init() in mac80211 allocates something like 1/2 MB of memory in a
> kmalloc() call and I see it failing frequently in our automation now ...
> Could we move that to vmalloc()?
Sure, don't see why not. The qdisc allocators all use kvmalloc() for the
same purpose, so I guess we can just switch fq_init() to that as well.
I'll send a (one-character :)) patch...
-Toke
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-05 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-05 14:57 fq_init() allocation Johannes Berg
2019-11-05 15:44 ` Toke Høiland-Jørgensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).