Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes

["Toke Høiland-Jørgensen" <toke@toke.dk>]

Kalle Valo <kvalo@codeaurora.org> writes:

> Johannes Berg <johannes@sipsolutions.net> writes:
>
>> On Wed, 2018-05-09 at 11:36 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrot=
e:
>>> Johannes Berg <johannes@sipsolutions.net> writes:
>>>=20
>>> > On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
>>> > > Johannes Berg <johannes@sipsolutions.net> writes:
>>> > >=20
>>> > > > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
>>> > > > >=20
>>> > > > > I guess these warnings come because Toke's patch increased size=
 of
>>> > > > > struct cfg80211_tid_stats (which is included in struct station_=
info) and
>>> > > > > both wil6210 and qtnfmac allocate a struct station_info from st=
ack?=20
>>> > > >=20
>>> > > > Yes.
>>> > > >=20
>>> > > > > Can
>>> > > > > someone send a fix for the drivers?
>>> > > >=20
>>> > > > I guess Toke/I should do that through my tree.
>>> > >=20
>>> > > IMHO the fix could go through my tree as well, less risk of conflic=
ts in
>>> > > drivers. AFAICS the fix (allocating station_info dynamically?) woul=
d not
>>> > > depend on Toke's patch and could be applied separately.
>>> >=20
>>> > That's true, if you prefer that it's fine with me.
>>>=20
>>> I'll send a patch.
>>>=20
>>> What's the right tag to put in the commit for this?
>>> Fixes-but-is-independent-from: ? ;)
>>
>> Heh. You can still put Fixes: I think.
>
> Yeah, I think so too.

Cool. My "git grep 'struct station_info sinfo'" also shows up a driver
in staging; that should be fixed as well, right? In the same commit?

-Toke