From: Kalle Valo <kvalo@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: Govind Singh <govinds@codeaurora.org>,
devicetree@vger.kernel.org, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
Date: Mon, 16 Apr 2018 18:00:38 +0300 [thread overview]
Message-ID: <878t9np561.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180413215340.vhvlhlaapt5uuo7d@rob-hp-laptop> (Rob Herring's message of "Fri, 13 Apr 2018 16:53:40 -0500")
Rob Herring <robh@kernel.org> writes:
> On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote:
>> Add device tree binding documentation details for wcn3990
>> wifi block present in Qualcomm SDM845/APQ8098 SoC into
>> "qcom,ath10k.txt".
>>
>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>> ---
>> .../bindings/net/wireless/qcom,ath10k.txt | 31 ++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>
> One nit, otherwise:
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
[...]
>> @@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
>> qcom,msi_base = <0x40>;
>> qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
>> };
>> +
>> +Example (to supply wcn3990 SoC wifi block details):
>> +
>> +qcom,wifi@18000000 {
>
> wifi@...
I added this and Rob's Reviewed-by to the patch in the pending branch:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=20f4accbe76af8f137b4218ce4973bda6fc3d23e
Govind, please check that it's ok.
--
Kalle Valo
next prev parent reply other threads:[~2018-04-16 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 16:49 [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block Govind Singh
2018-04-13 21:53 ` Rob Herring
2018-04-16 15:00 ` Kalle Valo [this message]
2018-04-17 4:27 ` govinds
-- strict thread matches above, loose matches on Subject: below --
2018-03-23 5:03 [PATCH v2 00/13] ***Set4: Add support of WCN3990 bus layer support *** Govind Singh
2018-03-23 5:03 ` [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block Govind Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t9np561.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=govinds@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).