linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: AceLan Kao <acelan.kao@canonical.com>,
	QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	"Linux-Kernel\@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	Daniel Drake <drake@endlessm.com>
Subject: Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically
Date: Tue, 26 Sep 2017 17:14:53 +0300	[thread overview]
Message-ID: <878th14kde.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20170926140413.GA19977@infradead.org> (Christoph Hellwig's message of "Tue, 26 Sep 2017 07:04:13 -0700")

Christoph Hellwig <hch@infradead.org> writes:

> On Tue, Sep 26, 2017 at 03:26:51PM +0800, AceLan Kao wrote:
>> Ath9k is an old driver for old chips, and they work fine with legacy INTx.
>> But some new platforms are using it, so I think we should list those
>> new platforms which blocks INTx in the driver.
>
> And unless they are broken and need a quirk they should work even better
> with MSI if the device advertises MSI support in the PCI capabilities.

Daniel Drake (CCed) already found problems with the MSI implementation:

https://lkml.kernel.org/r/20170925041153.26574-1-drake@endlessm.com

-- 
Kalle Valo

  reply	other threads:[~2017-09-26 14:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-26  6:41 [PATCH 1/6] ath9k: add MSI support and use_msi parameter AceLan Kao
2017-09-26  6:41 ` [PATCH 2/6] ath9k: add a quirk to set use_msi automatically AceLan Kao
2017-09-26  6:44   ` Christoph Hellwig
2017-09-26  7:26     ` AceLan Kao
2017-09-26 14:04       ` Christoph Hellwig
2017-09-26 14:14         ` Kalle Valo [this message]
2017-09-28  8:28           ` AceLan Kao
2017-10-02  4:21             ` Daniel Drake
2017-10-05  6:39               ` AceLan Kao
2017-10-13  1:12                 ` AceLan Kao
2017-10-13  1:17                   ` Daniel Drake
2017-09-26  6:41 ` [PATCH 3/6] ath9k: set use_msi=1 on Dell Vostro 3262 AceLan Kao
2017-09-26  6:41 ` [PATCH 4/6] ath9k: set use_msi=1 on Dell Inspiron 3472 AceLan Kao
2017-09-26  6:41 ` [PATCH 5/6] ath9k: set use_msi=1 on Dell Vostro 15-3572 AceLan Kao
2017-09-26  6:41 ` [PATCH 6/6] ath9k: set use_msi=1 on Dell Inspiron 14-3473 AceLan Kao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878th14kde.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=acelan.kao@canonical.com \
    --cc=ath9k-devel@qca.qualcomm.com \
    --cc=drake@endlessm.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).