From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>,
Yan-Hsuan Chuang <yhchuang@realtek.com>,
Birming Chiu <birming@realtek.com>, Shaofu <shaofu@realtek.com>,
Steven Ting <steventing@realtek.com>
Subject: Re: [PATCH 11/11] rtlwifi: btcoexist control to enter/leave LPS
Date: Wed, 21 Jun 2017 17:57:19 +0300 [thread overview]
Message-ID: <878tklo0c0.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20170618161249.6146-12-Larry.Finger@lwfinger.net> (Larry Finger's message of "Sun, 18 Jun 2017 11:12:49 -0500")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> From: Ping-Ke Shih <pkshih@realtek.com>
>
> To yield better user experience, have btcoex control LPS's parameters.
>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
> Cc: Birming Chiu <birming@realtek.com>
> Cc: Shaofu <shaofu@realtek.com>
> Cc: Steven Ting <steventing@realtek.com>
[...]
> - u8 rlbm, power_state = 0, byte5 = 0x40;
> + u8 rlbm, power_state = 0, byte5 = 0;
[...]
> + if ((rlbm == 2) && (byte5 & BIT(4))) {
> + /* Keep awake interval to 1 to prevent from
> + * decreasing coex performance
> + */
> + awake_intvl = 2;
> + rlbm = 2;
> + }
These kind of magic values (byte5 & BIT(4)) don't really belong in
upstream drivers and I'm seeing way too much of those in rtlwifi.
I'm not going to drop this patch because of this but please make an
effort to do packet parsing properly, for example with help of structs
and defines/enums.
--
Kalle Valo
prev parent reply other threads:[~2017-06-21 14:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-18 16:12 [PATCH 00/11] rtlwifi: Update drivers for various changes in btcoex Larry Finger
2017-06-18 16:12 ` [PATCH 01/11] rtlwifi: btcoex: call bind to setup btcoex Larry Finger
2017-06-21 15:28 ` [01/11] " Kalle Valo
2017-06-18 16:12 ` [PATCH 02/11] rtlwifi: btcoex: set correct interface type and parameter Larry Finger
2017-06-18 16:12 ` [PATCH 03/11] rtlwifi: btcoex: rtl8723be: fix ant_sel not work Larry Finger
2017-06-18 16:12 ` [PATCH 04/11] rtlwifi: Correct power save capability while init mac80211 Larry Finger
2017-06-18 16:12 ` [PATCH 05/11] rtlwifi: extend debug_comp to u64 Larry Finger
2017-06-18 16:12 ` [PATCH 06/11] rtlwifi: Add TX report and disable key to force wait until report acked Larry Finger
2017-06-18 16:12 ` [PATCH 07/11] rtlwifi: Revise special packet notification to be readable format Larry Finger
2017-06-18 16:12 ` [PATCH 08/11] rtlwifi: Add btcoex record_pwr_mode Larry Finger
2017-06-18 16:12 ` [PATCH 09/11] rtlwifi: Add rx ampdu cfg for btcoexist Larry Finger
2017-06-18 16:12 ` [PATCH 10/11] rtlwifi: add btc_is_bt_lps_on() " Larry Finger
2017-06-18 16:12 ` [PATCH 11/11] rtlwifi: btcoexist control to enter/leave LPS Larry Finger
2017-06-21 14:57 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tklo0c0.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=birming@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=shaofu@realtek.com \
--cc=steventing@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).