From: Kalle Valo <kvalo@codeaurora.org>
To: Amitkumar Karwar <amitkarwar@gmail.com>
Cc: linux-wireless@vger.kernel.org, Alexey.Brodkin@synopsys.com,
Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
Amitkumar Karwar <amit.karwar@redpinesignals.com>
Subject: Re: [PATCH 6/6] rsi: add tx frame for common device configuration
Date: Wed, 14 Jun 2017 12:07:36 +0300 [thread overview]
Message-ID: <878tkvos2v.fsf@purkki.adurom.net> (raw)
In-Reply-To: <1496412785-8720-7-git-send-email-amit.karwar@redpinesignals.com> (Amitkumar Karwar's message of "Fri, 2 Jun 2017 19:43:05 +0530")
Amitkumar Karwar <amitkarwar@gmail.com> writes:
> From: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
>
> After successful loading of firmware, a CARD READY indication is
> received by host. Common device configuration parameters are sent
> to the device after this. It includes information like device
> operating mode (Wi-Fi alone or BT coex), power save related
> parameters, GPIO information etc. As device supports BT coex,
> this frame is send in COEX queue initially. Based on the operating
> mode, CARD READY indication is received from each protocol module
> in firmware i.e. WLAN, BT.
>
> Signed-off-by: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
> Signed-off-by: Amitkumar Karwar <amit.karwar@redpinesignals.com>
[...]
> +static struct rsi_soc_gpio_vals unused_soc_gpio_bitmap = {
> + .pspi_csn_0 = USED_GPIO, //GPIO_0
> + .pspi_csn_1 = USED_GPIO, //GPIO_1
> + .host_wakeup_intr = USED_GPIO, //GPIO_2
> + .pspi_data_0 = USED_GPIO, //GPIO_3
> + .pspi_data_1 = USED_GPIO, //GPIO_4
> + .pspi_data_2 = USED_GPIO, //GPIO_5
> + .pspi_data_3 = USED_GPIO, //GPIO_6
> + .i2c_scl = USED_GPIO, //GPIO_7
> + .i2c_sda = USED_GPIO, //GPIO_8
> + .uart1_rx = UNUSED_GPIO, //GPIO_9
> + .uart1_tx = UNUSED_GPIO, //GPIO_10
> + .uart1_rts_i2s_clk = UNUSED_GPIO, //GPIO_11
> + .uart1_cts_i2s_ws = UNUSED_GPIO, //GPIO_12
> + .dbg_uart_rx_i2s_din = UNUSED_GPIO, //GPIO_13
> + .dbg_uart_tx_i2s_dout = UNUSED_GPIO, //GPIO_14
> + .lp_wakeup_boot_bypass = UNUSED_GPIO, //GPIO_15
> + .led_0 = USED_GPIO, //GPIO_16
> + .btcoex_wlan_active_ext_pa_ant_sel_A = UNUSED_GPIO, //GPIO_17
> + .btcoex_bt_priority_ext_pa_ant_sel_B = UNUSED_GPIO, //GPIO_18
> + .btcoex_bt_active_ext_pa_on_off = UNUSED_GPIO, //GPIO_19
> + .rf_reset = USED_GPIO, //GPIO_20
> + .sleep_ind_from_device = UNUSED_GPIO,
> +};
No //, please. Use instead /* */.
--
Kalle Valo
next prev parent reply other threads:[~2017-06-14 9:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 14:12 [PATCH 0/6] rsi driver bringup changes Amitkumar Karwar
2017-06-02 14:13 ` [PATCH 1/6] rsi: add usb RS9113 chipset support Amitkumar Karwar
2017-06-02 14:13 ` [PATCH 2/6] rsi: use enum for FSM states Amitkumar Karwar
2017-06-13 6:47 ` Kalle Valo
2017-06-13 14:47 ` amit karwar
2017-06-14 9:13 ` Kalle Valo
2017-06-14 14:25 ` Amitkumar Karwar
2017-06-15 14:44 ` Kalle Valo
2017-06-16 15:02 ` Amitkumar Karwar
2017-06-19 15:19 ` Kalle Valo
2017-06-20 13:26 ` Amitkumar Karwar
2017-06-02 14:13 ` [PATCH 3/6] rsi: Register interrupt handler before firmware load Amitkumar Karwar
2017-06-02 14:13 ` [PATCH 4/6] rsi: receive path enhancement for RS9113 Amitkumar Karwar
2017-06-02 14:13 ` [PATCH 5/6] rsi: configure new boot parameters to device Amitkumar Karwar
2017-06-02 14:13 ` [PATCH 6/6] rsi: add tx frame for common device configuration Amitkumar Karwar
2017-06-14 9:04 ` Kalle Valo
2017-06-14 14:17 ` Amitkumar Karwar
2017-06-14 9:07 ` Kalle Valo [this message]
2017-06-14 14:18 ` Amitkumar Karwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tkvos2v.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=Alexey.Brodkin@synopsys.com \
--cc=amit.karwar@redpinesignals.com \
--cc=amitkarwar@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=prameela.j04cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).