From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <greearb@candelatech.com>
Cc: <linux-wireless@vger.kernel.org>, <ath10k@lists.infradead.org>
Subject: Re: [PATCH 1/3] ath10k: use 64-bit vdev map.
Date: Tue, 23 Sep 2014 15:54:31 +0300 [thread overview]
Message-ID: <878ulaebug.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1411149890-12618-1-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Fri, 19 Sep 2014 11:04:48 -0700")
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> This can allow more than 32 stations to be supported
> without over-running the bitmap.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
[...]
> - ar->monitor_vdev_id = bit - 1;
> + ar->monitor_vdev_id = bit;
[...]
> - arvif->vdev_id = bit - 1;
> + ath10k_warn(ar, "Creating vdev id: %i map: %llu\n",
> + bit, ar->free_vdev_map);
> +
> + arvif->vdev_id = bit;
Why remove the "- 1"? Are you sure that's not going to break any
assumptions somewhere?
--
Kalle Valo
next prev parent reply other threads:[~2014-09-23 12:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 18:04 [PATCH 1/3] ath10k: use 64-bit vdev map greearb
2014-09-19 18:04 ` [PATCH 2/3] ath10k: support CT firmware flag greearb
2014-09-19 18:04 ` [PATCH 3/3] ath10k: support 32+ stations greearb
2014-09-23 12:59 ` Kalle Valo
2014-09-23 14:58 ` Ben Greear
2014-09-23 9:04 ` [PATCH 1/3] ath10k: use 64-bit vdev map Michal Kazior
2014-09-23 12:54 ` Kalle Valo [this message]
2014-09-23 14:21 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ulaebug.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).