From: Kalle Valo <kvalo@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Youghandhar Chintala <quic_youghand@quicinc.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v2] wifi: ath10k: Delay the unmapping of the buffer
Date: Wed, 12 Oct 2022 18:30:48 +0300 [thread overview]
Message-ID: <87a661njo7.fsf@kernel.org> (raw)
In-Reply-To: <1c64fe906b36438d63a7fc3fc9d0ab010b6db42f.camel@sipsolutions.net> (Johannes Berg's message of "Wed, 12 Oct 2022 16:49:03 +0200")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Wed, 2022-10-12 at 19:57 +0530, Youghandhar Chintala wrote:
>>
>> @@ -418,6 +426,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
>> .dynamic_sar_support = false,
>> .hw_restart_disconnect = false,
>> .use_fw_tx_credits = true,
>> + .delay_unmap_buffer = false,
>>
>
> All the false are unnecessary and just distract from the content, imho.
In this case I actually prefer having explicitly set false (and zero),
it makes it easier to maintain the correct order and compare between
hardware values.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-10-12 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 14:27 [PATCH v2] wifi: ath10k: Delay the unmapping of the buffer Youghandhar Chintala
2022-10-12 14:34 ` Adrian Chadd
2022-10-12 14:49 ` Johannes Berg
2022-10-12 15:30 ` Kalle Valo [this message]
2022-10-19 5:44 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a661njo7.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=dianders@chromium.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_youghand@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).