From: Kalle Valo <kvalo@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: "Jérôme Pouiller" <jerome.pouiller@silabs.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wfx: avoid flush_workqueue(system_highpri_wq) usage
Date: Mon, 02 May 2022 09:25:48 +0300 [thread overview]
Message-ID: <87a6c0cuxf.fsf@kernel.org> (raw)
In-Reply-To: <3841528e-78ae-c3c4-169a-eeb39714f7ca@I-love.SAKURA.ne.jp> (Tetsuo Handa's message of "Sun, 1 May 2022 19:23:16 +0900")
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> writes:
> On 2022/05/01 17:53, Kalle Valo wrote:
>> So now the thread is created every time the module loaded, even if
>> there's no device available.
>
> Excuse me, but what thread?
Sorry, s/thread/workqueue/.
> alloc_workqueue() without WQ_MEM_RECLAIM flag does not create a
> thread, and therefore consumes little resource where there's no device
> available does not matter.
It still allocating memory which is not needed. To me allocating
resources during module_init is wrong.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-05-02 6:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 11:23 [PATCH 00/10] staging: wfx: usual maintenance Jerome Pouiller
2022-02-25 11:23 ` [PATCH 01/10] staging: wfx: sta.o was linked twice Jerome Pouiller
2022-02-25 11:23 ` [PATCH 02/10] staging: wfx: fix struct alignment Jerome Pouiller
2022-02-25 11:23 ` [PATCH 03/10] staging: wfx: format comments on 100 columns Jerome Pouiller
2022-03-01 1:12 ` Joe Perches
2022-03-01 17:13 ` Jeff Johnson
2022-02-25 11:23 ` [PATCH 04/10] staging: wfx: format code " Jerome Pouiller
2022-02-25 11:24 ` [PATCH 05/10] staging: wfx: remove useless variable Jerome Pouiller
2022-02-25 11:24 ` [PATCH 06/10] staging: wfx: drop useless include Jerome Pouiller
2022-02-25 11:24 ` [PATCH 07/10] staging: wfx: remove duplicated code in wfx_cmd_send() Jerome Pouiller
2022-02-25 11:24 ` [PATCH 08/10] staging: wfx: prefer to wait for an event instead to sleep Jerome Pouiller
2022-02-25 11:24 ` [PATCH 09/10] staging: wfx: ensure HIF request has been sent before polling Jerome Pouiller
2022-04-12 13:11 ` Tetsuo Handa
2022-04-13 15:18 ` Jérôme Pouiller
2022-05-01 6:01 ` [PATCH] wfx: avoid flush_workqueue(system_highpri_wq) usage Tetsuo Handa
2022-05-01 8:53 ` Kalle Valo
2022-05-01 10:23 ` Tetsuo Handa
2022-05-02 6:25 ` Kalle Valo [this message]
2022-05-02 8:16 ` [PATCH v2] " Tetsuo Handa
2022-05-02 8:38 ` Jérôme Pouiller
2022-05-02 9:02 ` Kalle Valo
2022-05-04 5:29 ` [v2] " Kalle Valo
2022-05-02 8:48 ` [PATCH] " Jérôme Pouiller
2022-02-25 11:24 ` [PATCH 10/10] staging: wfx: flags for SPI IRQ were ignored Jerome Pouiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6c0cuxf.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=jerome.pouiller@silabs.com \
--cc=linux-wireless@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).