From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Wenli Looi <wlooi@ucalgary.ca>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com,
Wenli Looi <wlooi@ucalgary.ca>
Subject: Re: [PATCH 4/6] ath9k: fix ar9003_get_eepmisc
Date: Mon, 21 Mar 2022 16:51:11 +0100 [thread overview]
Message-ID: <87a6dj9uds.fsf@toke.dk> (raw)
In-Reply-To: <20220320233010.123106-5-wlooi@ucalgary.ca>
Wenli Looi <wlooi@ucalgary.ca> writes:
> The current implementation is reading the wrong eeprom type.
>
> Fixes: d8ec2e ("ath9k: Add an eeprom_ops callback for retrieving the eepmisc value")
> Signed-off-by: Wenli Looi <wlooi@ucalgary.ca>
> ---
> drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> index 669b49b56..a109a44a1 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> @@ -5615,7 +5615,7 @@ unsigned int ar9003_get_paprd_scale_factor(struct ath_hw *ah,
>
> static u8 ar9003_get_eepmisc(struct ath_hw *ah)
> {
> - return ah->eeprom.map4k.baseEepHeader.eepMisc;
> + return ah->eeprom.ar9300_eep.baseEepHeader.opCapFlags.eepMisc;
> }
Looks like this is only ever used to check for the
AR5416_EEPMISC_BIG_ENDIAN flag - so is that never used by AR9300, or how
was this ever working given that it's a completely different offset?
-Toke
next prev parent reply other threads:[~2022-03-21 15:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 23:30 [PATCH 0/6] ath9k: suggested improvements and bugfixes Wenli Looi
2022-03-20 23:30 ` [PATCH 1/6] ath9k: make ATH_SREV macros more consistent Wenli Looi
2022-03-21 16:02 ` Toke Høiland-Jørgensen
2022-03-25 10:34 ` Kalle Valo
2022-03-20 23:30 ` [PATCH 2/6] ath9k: split set11nRateFlags and set11nChainSel Wenli Looi
2022-03-21 16:02 ` Toke Høiland-Jørgensen
2022-03-20 23:30 ` [PATCH 3/6] ath9k: use AR9300_MAX_CHAINS when appropriate Wenli Looi
2022-03-21 16:02 ` Toke Høiland-Jørgensen
2022-03-20 23:30 ` [PATCH 4/6] ath9k: fix ar9003_get_eepmisc Wenli Looi
2022-03-21 15:51 ` Toke Høiland-Jørgensen [this message]
2022-03-21 19:57 ` Wenli Looi
2022-03-21 21:07 ` Toke Høiland-Jørgensen
2022-03-21 21:07 ` Toke Høiland-Jørgensen
2022-03-23 9:30 ` Kalle Valo
2022-03-23 11:15 ` Toke Høiland-Jørgensen
2022-03-23 12:16 ` Kalle Valo
2022-03-23 12:34 ` Toke Høiland-Jørgensen
2022-03-24 15:51 ` Wenli Looi
2022-03-20 23:30 ` [PATCH 5/6] ath9k: refactor ar9003_hw_spur_mitigate_ofdm Wenli Looi
2022-03-21 16:03 ` Toke Høiland-Jørgensen
2022-03-20 23:30 ` [PATCH 6/6] ath9k: add functions to get paprd rate mask Wenli Looi
2022-03-21 16:03 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6dj9uds.fsf@toke.dk \
--to=toke@toke.dk \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wlooi@ucalgary.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).