From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CAC9C433EF for ; Thu, 7 Oct 2021 09:48:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DDCB61090 for ; Thu, 7 Oct 2021 09:48:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240465AbhJGJuc (ORCPT ); Thu, 7 Oct 2021 05:50:32 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:18146 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240569AbhJGJuc (ORCPT ); Thu, 7 Oct 2021 05:50:32 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1633600118; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=vGI68wyoqpDAZBA89Pt6Cbg+azmy5aIwL+2+C+Cr1xA=; b=VQONH5PEtvJrVLkaE5qyYfD4oEDQRDUaxbYYt5Xwi+SmOawyG1Vj8X3EOTHM6sBHJDR42MpA elt/LKb7sFWAk0CBnZ3SZERYA87aN8RRs0q+fqHtOOOQ6lG2LwjwPWHx6r0ZdEy7JMMR+1SP rLOGCgLN4iiVRRbjlZ0D35CdvgM= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 615ec26ba45ca753078edd37 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 07 Oct 2021 09:48:27 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BDE82C43616; Thu, 7 Oct 2021 09:48:26 +0000 (UTC) Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 56A93C4338F; Thu, 7 Oct 2021 09:48:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 56A93C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Loic Poulain Cc: Manivannan Sadhasivam , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-arm-msm , regressions@lists.linux.dev, mhi Subject: Re: [regression] mhi: ath11k resume fails on some devices References: <871r5p0x2u.fsf@codeaurora.org> <877df6tlnq.fsf@codeaurora.org> Date: Thu, 07 Oct 2021 12:48:19 +0300 In-Reply-To: (Loic Poulain's message of "Fri, 24 Sep 2021 11:43:55 +0200") Message-ID: <87a6jl9ndo.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org (adding the new mhi list, yay) Hi Loic, Loic Poulain writes: >> Loic Poulain writes: >> >> > On Thu, 16 Sept 2021 at 10:00, Kalle Valo wrote: >> >> >> At the moment I'm running my tests with commit 020d3b26c07a reverted and >> >> everything works without problems. Is there a simple way to fix this? Or >> >> maybe we should just revert the commit? Commit log and kernel logs from >> >> a failing case below. >> > >> > Do you have log of success case? >> >> A log from a successful case in the end of email, using v5.15-rc1 plus >> revert of commit 020d3b26c07abe27. >> >> > To me, the device loses power, that is why MHI resuming is failing. >> > Normally the device should be properly recovered/reinitialized. Before >> > that patch the power loss was simply not detected (or handled at >> > higher stack level). >> >> Currently in ath11k we always keep the firmware running when in suspend, >> this is a workaround due to problems between mac80211 and MHI stack. >> IIRC the problem was something related MHI creating struct device during >> resume or something like that. > > Could you give a try with the attached patch? It should solve your > issue without breaking modem support. Sorry for taking so long, but I now tested your patch on top of v5.15-rc3 and, as expected, everything works as before with QCA6390 on NUC x86 testbox. Tested-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches