From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Felix Fietkau <nbd@nbd.name>, linux-wireless@vger.kernel.org
Cc: johannes@sipsolutions.net
Subject: Re: [PATCH] mac80211: remove STA txq pending airtime underflow warning
Date: Tue, 11 Aug 2020 11:31:16 +0200 [thread overview]
Message-ID: <87a6z134wr.fsf@toke.dk> (raw)
In-Reply-To: <20200725084533.13829-1-nbd@nbd.name>
Felix Fietkau <nbd@nbd.name> writes:
> This warning can trigger if there is a mismatch between frames that were
> sent with the sta pointer set vs tx status frames reported for the sta address.
>
> This can happen due to race conditions on re-creating stations, or even
> in the case of .sta_add/remove being used instead of .sta_state, which can cause
> frames to be sent to a station that has not been uploaded yet.
>
> If there is an actual underflow issue, it should show up in the device airtime
> warning below, so it is better to remove this one.
Fair enough.
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
prev parent reply other threads:[~2020-08-11 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 8:45 [PATCH] mac80211: remove STA txq pending airtime underflow warning Felix Fietkau
2020-08-11 9:31 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6z134wr.fsf@toke.dk \
--to=toke@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).