From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F13EBC433E0 for ; Wed, 27 May 2020 12:39:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA3AC207CB for ; Wed, 27 May 2020 12:39:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="v7Mhq7AL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730092AbgE0MjX (ORCPT ); Wed, 27 May 2020 08:39:23 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:26866 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728964AbgE0MjW (ORCPT ); Wed, 27 May 2020 08:39:22 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1590583162; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=k+wLv6pKXT7nlyf+aOv3Skb3ZTtkuUFqJ25fOD4zXVQ=; b=v7Mhq7ALASr2UZBx9snj3y5k8zHhTUeh/Pun7aAV+S8MaZnQNG/DPbCKpPT89qZkB2+0SI74 mB08ApCLlaxGv9QxD6wy/tcG1741qb+Oa0jILipEbLWiptHQ4SZSYekakySgwPVLVRLZt7ZE +qW0b+gCLFb2EmRSVJT9SQuI6z8= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 5ece5f6d44a25e0052246b25 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 27 May 2020 12:39:09 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 8F20DC43387; Wed, 27 May 2020 12:39:08 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id E1B89C433CA; Wed, 27 May 2020 12:39:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E1B89C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Larry Finger Cc: linux-wireless@vger.kernel.org, Rui Salvaterra , Stable Subject: Re: [PATCH 2/2] b43_legacy: Fix connection problem with WPA3 References: <20200526155909.5807-1-Larry.Finger@lwfinger.net> <20200526155909.5807-3-Larry.Finger@lwfinger.net> Date: Wed, 27 May 2020 15:39:05 +0300 In-Reply-To: <20200526155909.5807-3-Larry.Finger@lwfinger.net> (Larry Finger's message of "Tue, 26 May 2020 10:59:09 -0500") Message-ID: <87a71tv9g6.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Larry Finger writes: > Since the driver was first introduced into the kernel, it has only > handled the ciphers associated with WEP, WPA, and WPA2. It fails with > WPA3 even though mac80211 can handle those additional ciphers in software, > b43legacy did not report that it could handle them. By setting MFP_CAPABLE using > ieee80211_set_hw(), the problem is fixed. > > With this change, b43legacy will handle the ciohers it knows in hardare, > and let mac80211 handle the others in software. It is not necessary to > use the module parameter NOHWCRYPT to turn hardware encryption off. > Although this change essentially eliminates that module parameter, > I am choosing to keep it for cases where the hardware is broken, > and software encryption is required for all ciphers. > > This patch fixes a problem that has been in b43legacy since commit > 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx > devices"). > > Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices") > Signed-off-by: Larry Finger > Cc: Stable I'll do the same changes here as in patch 1. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches