From: Kalle Valo <kvalo@codeaurora.org>
To: Tony Chuang <yhchuang@realtek.com>
Cc: "linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"briannorris\@chromium.org" <briannorris@chromium.org>,
Arend Van Spriel <arend.vanspriel@broadcom.com>,
Johannes Berg <johannes@sipsolutions.net>,
"tamizhr\@codeaurora.org" <tamizhr@codeaurora.org>
Subject: Re: [PATCH v2 2/2] rtw88: add a debugfs entry to enable/disable coex mechanism
Date: Fri, 13 Mar 2020 13:17:09 +0200 [thread overview]
Message-ID: <87a74ko66i.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <33d4904b71a04ed8b0226ce07b037e05@realtek.com> (Tony Chuang's message of "Fri, 13 Mar 2020 02:23:38 +0000")
Tony Chuang <yhchuang@realtek.com> writes:
> Kalle Valo <kvalo@codeaurora.org> :
>
>> <yhchuang@realtek.com> writes:
>>
>> > From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>> >
>> > Sometimes we need to stop the coex mechanism to debug, so that we
>> > can manually control the device through various outer commands.
>> > Hence, add a new debugfs coex_enable to allow us to enable/disable
>> > the coex mechanism when driver is running.
>> >
>> > To disable coex
>> > echo 0 > /sys/kernel/debug/ieee80211/phyX/rtw88/coex_enable
>> >
>> > To enable coex
>> > echo 1 > /sys/kernel/debug/ieee80211/phyX/rtw88/coex_enable
>> >
>> > To check coex dm is enabled or not
>> > cat /sys/kernel/debug/ieee80211/phyX/rtw88/coex_enable
>>
>> I forgot, did we add a command to nl80211 for managing btcoex? At least
>> we have talking about that for years. Please check that first before
>> adding a debugfs interface for this.
>>
>
> Yes, I found there was a thread [1] talking about adding a callback to
> enable/disable btcoex, but it seems not get applied eventually.
Too bad, I really think we should have at least enable/disable
functionality in nl80211. But if it's not there, I guess it's ok to have
yet another driver custom debugfs file :/
> And there's another thread [2] talking about add a btcoex subsystem.
> But seems like nobody can implement it cleanly in the host.
>
> I think adding btcoex subsystem could have a lot of pain since each
> vendor is using different mechanism controlling the btcoex, and it
> usually comes with RF related design which is difficult to write a common
> function to deal with all kinds of them.
Yeah, btcoex subsystem is a big challenge.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-03-13 11:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 7:58 [PATCH v2 0/2] rtw88: add coex related debugfs yhchuang
2020-03-09 7:58 ` [PATCH v2 1/2] rtw88: add a debugfs entry to dump coex's info yhchuang
2020-03-11 9:31 ` Chris Chiu
2020-03-12 13:23 ` Kalle Valo
2020-03-09 7:58 ` [PATCH v2 2/2] rtw88: add a debugfs entry to enable/disable coex mechanism yhchuang
2020-03-12 13:25 ` Kalle Valo
2020-03-13 2:23 ` Tony Chuang
2020-03-13 11:17 ` Kalle Valo [this message]
2020-03-16 2:13 ` Tony Chuang
2020-03-24 7:05 ` Tony Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a74ko66i.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=briannorris@chromium.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tamizhr@codeaurora.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).