From: Kalle Valo <kvalo@codeaurora.org>
To: Surabhi Vishnoi <svishnoi@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] ath10k: Add support for per peer HTT tx stats for WCN3990
Date: Mon, 23 Sep 2019 11:12:07 +0300 [thread overview]
Message-ID: <87a7ava0tk.fsf@codeaurora.org> (raw)
In-Reply-To: <1551251628-22518-3-git-send-email-svishnoi@codeaurora.org> (Surabhi Vishnoi's message of "Wed, 27 Feb 2019 12:43:48 +0530")
Surabhi Vishnoi <svishnoi@codeaurora.org> writes:
> The firmware sends peer stats to the host driver if the firmware
> advertises WMI_SERVICE_PEER_STATS service and the host driver
> indicates the WMI_RSRC_CFG_FLAG_TX_PEER_STATS capability in the
> host capab flag in wmi init cmd.
>
> When peer stats are enabled, firmware sends one HTT event
> HTT_TLV_T2H_MSG_TYPE_PEER_STATS for every four PPDUs transmitted.
> HTT msg payload has tag followed by length followed by
> success pkts/bytes, failed pkts/bytes, retry pkts/bytes and rate
> info per ppdu.
>
> Parse peer stats sent by the firmware in tlv format and update the
> tx rate information and tx_stats debugfs entry per STA.
>
> To get the tx_stats:
> echo 1 > /sys/kernel/debug/ieee80211/phyX/ath10k/enable_extd_tx_stats
> cat /sys/kernel/debug/ieee80211/phyX/net:wlanX/stations/xx:xx:xx:xx:xx:xx/tx_stats
>
> Tested HW: WCN3990
> Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1
>
> Signed-off-by: Surabhi Vishnoi <svishnoi@codeaurora.org>
[...]
> @@ -3438,7 +3566,7 @@ bool ath10k_htt_t2h_msg_handler(struct ath10k *ar, struct sk_buff *skb)
> ath10k_htt_rx_tx_mode_switch_ind(ar, skb);
> break;
> case HTT_T2H_MSG_TYPE_PEER_STATS:
> - ath10k_htt_fetch_peer_stats(ar, skb);
> + htt->rx_ops->htt_fetch_peer_stats(ar, skb);
> break;
I think this belongs to patch 1.
> +#define ATH10K_HW_GI_MASK GENMASK(5, 5)
BIT(5)
> +#define ATH10K_HW_SKIPPED_RATE_CTRL_MASK GENMASK(6, 6)
BIT(6)
> +#define ATH10K_HW_WCN3990_GI_MASK GENMASK(6, 6)
BIT(6)
> +#define ATH10K_HW_WCN3990_SKIPPED_RATE_CTRL_MASK GENMASK(7, 7)
BIT(7)
--
Kalle Valo
prev parent reply other threads:[~2019-09-23 8:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 7:13 [PATCH 0/2] Add support for per peer HTT tx stats for WCN3990 Surabhi Vishnoi
2019-02-27 7:13 ` [PATCH 1/2] ath10k: Add support for adding htt_rx_ops based on htt_version Surabhi Vishnoi
2019-09-23 8:07 ` Kalle Valo
2019-02-27 7:13 ` [PATCH 2/2] ath10k: Add support for per peer HTT tx stats for WCN3990 Surabhi Vishnoi
2019-09-23 8:12 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7ava0tk.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=svishnoi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).