From: Kalle Valo <kvalo@codeaurora.org>
To: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Cc: linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Wright Feng <wright.feng@cypress.com>,
Winnie Chang <winnie.chang@cypress.com>
Subject: Re: [PATCH] brcmfmac: fix brcmf_wiphy_wowl_params() NULL pointer dereference
Date: Tue, 07 Aug 2018 14:28:36 +0300 [thread overview]
Message-ID: <87a7py4dqz.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1533622686-145733-1-git-send-email-chi-hsien.lin@cypress.com> (Chi-Hsien Lin's message of "Tue, 7 Aug 2018 01:18:06 -0500")
Chi-Hsien Lin <chi-hsien.lin@cypress.com> writes:
> From: Winnie Chang <winnie.chang@cypress.com>
>
> The kernel BUG happens when wowl is enabled from firmware. In
> brcmf_wiphy_wowl_params(), cfg is a NULL pointer because it is
> drvr->config returned from wiphy_to_cfg(), and drvr->config is not set
> yet. To fix it, set drvr->config before brcmf_setup_wiphy() which
> calls brcmf_wiphy_wowl_params().
>
> The kernel panic is introduced in below commit:
> commit id: 856d5a011c86b59f6564be4508912fb1d866adfc
> brcmfmac: allocate struct brcmf_pub instance using wiphy_new()
>
> Signed-off-by: Winnie Chang <winnie.chang@cypress.com>
> Reviewed-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Chi-Hsien, you need to include your own s-o-b as well when you are
submitting the patch:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#signed-off-by_missing
--
Kalle Valo
next prev parent reply other threads:[~2018-08-07 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 6:18 [PATCH] brcmfmac: fix brcmf_wiphy_wowl_params() NULL pointer dereference Chi-Hsien Lin
2018-08-07 11:28 ` Kalle Valo [this message]
2018-08-07 13:40 ` Chi-Hsien Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7py4dqz.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=winnie.chang@cypress.com \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox