From: Kalle Valo <kvalo@codeaurora.org>
To: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
Cc: Tony Lindgren <tony@atomide.com>, Eyal Reizer <eyalr@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>, Guy Mishol <guym@ti.com>,
Luca Coelho <luciano.coelho@intel.com>,
Maital Hahn <maitalm@ti.com>,
Maxim Altshul <maxim.altshul@ti.com>,
Shahar Patury <shaharp@ti.com>,
linux-wireless@vger.kernel.org,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/2] wlcore: Add support runtime PM
Date: Wed, 16 May 2018 12:27:46 +0300 [thread overview]
Message-ID: <87a7t0lzl9.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CAOf5uwkT4Vg1kQn5k=_z9XjXOLWbA0vioqH6KSdikZbCwyaYbA@mail.gmail.com> (Michael Nazzareno Trimarchi's message of "Tue, 15 May 2018 18:17:39 +0200")
Michael Nazzareno Trimarchi <michael@amarulasolutions.com> writes:
>> @@ -315,15 +319,17 @@ static ssize_t dynamic_fw_traces_write(struct file *file,
>> if (unlikely(wl->state != WLCORE_STATE_ON))
>> goto out;
>>
>> - ret = wl1271_ps_elp_wakeup(wl);
>> - if (ret < 0)
>> + ret = pm_runtime_get_sync(wl->dev);
>> + if (ret < 0) {
>> + pm_runtime_put_noidle(wl->dev);
>> goto out;
>> + }
>>
>
> Can you just change ps_elp_wakeup with
> ret = pm_runtime_get_sync(wl->dev);
> if (ret < 0) {
> pm_runtime_put_noidle(wl->dev);
> goto out;
> }
>
>> ret = wl18xx_acx_dynamic_fw_traces(wl);
>> if (ret < 0)
>> count = ret;
>>
>> - wl1271_ps_elp_sleep(wl);
>> + pm_runtime_put(wl->dev);
>
> and elp_sleep with this one
>
>> out:
>> mutex_unlock(&wl->mutex);
>> return count;
>> @@ -374,9 +380,11 @@ static ssize_t radar_debug_mode_write(struct file *file,
>> if (unlikely(wl->state != WLCORE_STATE_ON))
>> goto out;
>>
>> - ret = wl1271_ps_elp_wakeup(wl);
>> - if (ret < 0)
>> + ret = pm_runtime_get_sync(wl->dev);
>> + if (ret < 0) {
>> + pm_runtime_put_noidle(wl->dev);
>> goto out;
>> + }
>>
>> wl12xx_for_each_wlvif_ap(wl, wlvif) {
>> wlcore_cmd_generic_cfg(wl, wlvif,
>> @@ -384,7 +392,7 @@ static ssize_t radar_debug_mode_write(struct file *file,
>> wl->radar_debug_mode, 0);
>> }
>>
>> - wl1271_ps_elp_sleep(wl);
>> + pm_runtime_put(wl->dev);
>
> Michael
<over 1600 lines of unnecessary quotation cut out>
PLEASE edit your quotes, your behaviour makes use of patchwork really
annoying:
https://patchwork.kernel.org/patch/10401591/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#do_not_top_post_and_edit_your_quotes
--
Kalle Valo
prev parent reply other threads:[~2018-05-16 9:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 16:13 [PATCH 0/2] Runtime PM support for wlcore Tony Lindgren
2018-05-15 16:13 ` [PATCH 1/2] wlcore: Make sure PM calls are paired Tony Lindgren
2018-05-16 15:43 ` Tony Lindgren
2018-05-16 16:17 ` Tony Lindgren
2018-05-15 16:13 ` [PATCH 2/2] wlcore: Add support runtime PM Tony Lindgren
2018-05-15 16:17 ` Michael Nazzareno Trimarchi
2018-05-15 16:25 ` Tony Lindgren
2018-05-16 9:27 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7t0lzl9.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=eyalr@ti.com \
--cc=guym@ti.com \
--cc=kishon@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=maitalm@ti.com \
--cc=maxim.altshul@ti.com \
--cc=michael@amarulasolutions.com \
--cc=shaharp@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).