Re: [PATCH v2 0/4] rtlwifi: btcoex: Remove all references to BT_AUTO_REPORT_ONLY* parameters

[Kalle Valo <kvalo@codeaurora.org>]

Larry Finger <Larry.Finger@lwfinger.net> writes:

> The btcoex code uses #if constructs to compile conditional code. There
> is no way to modify this behavior without editting the source. This
> logic is converted into regular if statements that interrogate a
> boolean variable in a structure known to all routines.

Well technically these are still dead code as there's no way to enable
those. But this is much better than before, now at least we can compile
test the whole code. So thanks for fixing it.

> The new form does not provide any mechanism for dynamic changes, but
> it now is in a form whereby module parameters could be added to select
> the behavior at module load time. In these patches, a number of
> routines removed because they were not referenced must be restored.

We should keep the number of module parameters as low as possible. If
I'm understanding correctly changing the behaviour is needed for testing
purposes? In that case I suspect that debugfs would be more approriate
interface to enable these.

-- 
Kalle Valo