From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [bug report] mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue
Date: Wed, 12 Oct 2016 17:57:56 +0200 [thread overview]
Message-ID: <87a8e91rwb.fsf@toke.dk> (raw)
In-Reply-To: <20161012061458.GM12841@mwanda> (Dan Carpenter's message of "Wed, 12 Oct 2016 09:14:58 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> Hello Toke H=C3=B8iland-J=C3=B8rgensen,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch bb42f2d13ffc: "mac80211: Move reorder-sensitive TX handlers=20
> to after TXQ dequeue" from Sep 22, 2016, leads to the following=20
> Smatch complaint:
>
> net/mac80211/tx.c:3242 ieee80211_xmit_fast_finish()
> error: we previously assumed 'key' could be null (see line 3209)
>
> net/mac80211/tx.c
> 3208=09
> 3209 if (key)
> ^^^
> Check.
>
> 3210 info->control.hw_key =3D &key->conf;
> 3211=09
> 3212 ieee80211_tx_stats(skb->dev, skb->len);
> 3213=09
> 3214 if (hdr->frame_control & cpu_to_le16(IEEE80211_STYPE_QOS_DATA)) {
> 3215 tid =3D skb->priority & IEEE80211_QOS_CTL_TAG1D_MASK;
> 3216 *ieee80211_get_qos_ctl(hdr) =3D tid;
> 3217 hdr->seq_ctrl =3D ieee80211_tx_next_seq(sta, tid);
> 3218 } else {
> 3219 info->flags |=3D IEEE80211_TX_CTL_ASSIGN_SEQ;
> 3220 hdr->seq_ctrl =3D cpu_to_le16(sdata->sequence_number);
> 3221 sdata->sequence_number +=3D 0x10;
> 3222 }
> 3223=09
> 3224 if (skb_shinfo(skb)->gso_size)
> 3225 sta->tx_stats.msdu[tid] +=3D
> 3226 DIV_ROUND_UP(skb->len, skb_shinfo(skb)->gso_size);
> 3227 else
> 3228 sta->tx_stats.msdu[tid]++;
> 3229=09
> 3230 info->hw_queue =3D sdata->vif.hw_queue[skb_get_queue_mapping(skb)=
];
> 3231=09
> 3232 /* statistics normally done by ieee80211_tx_h_stats (but that
> 3233 * has to consider fragmentation, so is more complex)
> 3234 */
> 3235 sta->tx_stats.bytes[skb_get_queue_mapping(skb)] +=3D skb->len;
> 3236 sta->tx_stats.packets[skb_get_queue_mapping(skb)]++;
> 3237=09
> 3238 if (pn_offs) {
> ^^^^^^^
> Maybe when pn_offs is non-zero that implies key is non-NULL?
Yes, it does. fast_tx->pn_offs is set in ieee80211_check_fast_xmit()
which only sets it if fast_tx->key is set. The other call to
ieee80211_xmit_fast_finish() is in ieee80211_tx_dequeue() which also
only sets pn_offs if the key is set.
-Toke
prev parent reply other threads:[~2016-10-12 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 6:14 [bug report] mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue Dan Carpenter
2016-10-12 15:57 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8e91rwb.fsf@toke.dk \
--to=toke@toke.dk \
--cc=dan.carpenter@oracle.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).