From: Kalle Valo <kvalo@qca.qualcomm.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Vasanthakumar Thiagarajan <vthiagar@qti.qualcomm.com>,
<linux-wireless@vger.kernel.org>, <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: remove NULL ptr deref in variable init of ath10k_monitor_vdev_start
Date: Tue, 28 Jul 2015 19:23:25 +0300 [thread overview]
Message-ID: <87a8ug8d4y.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20150728143124.GB17081@tuxdriver.com> (John W. Linville's message of "Tue, 28 Jul 2015 10:31:25 -0400")
"John W. Linville" <linville@tuxdriver.com> writes:
> On Tue, Jul 28, 2015 at 10:41:11AM +0530, Vasanthakumar Thiagarajan wrote:
>> On Tuesday 28 July 2015 12:52 AM, John W. Linville wrote:
>> >In ath10k_monitor_vdev_start, chandef is initialized to NULL and then
>> >channel is immediately thereafter initialized to chandef->chan (i.e.
>> >NULL->chan). This appears to be some sort of cut-n-paste error, since
>> >the same assignment is done later (i.e. after chandef has been properly
>> >assigned to a non-NULL value). So, let's just remove this "brown paper
>> >bag" typo/thinko... :-)
>> >
>> >Coverity CID #1309505
>> >
>> >Signed-off-by: John W. Linville <linville@tuxdriver.com>
[...]
>> There is a similar change integrated recently,
>> https://github.com/kvalo/ath/commit/19be9e9a7ac7e6050eab426283d2a87593cf6e82
>
> OK. I don't see much point in the NULL assignment for channel, but the main
> point is to avoide the chandef->chan part.
Yeah, that was an oversight in my review. Want to send a patch to fix
that? :)
--
Kalle Valo
prev parent reply other threads:[~2015-07-28 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 19:22 [PATCH] ath10k: remove NULL ptr deref in variable init of ath10k_monitor_vdev_start John W. Linville
2015-07-28 5:11 ` Vasanthakumar Thiagarajan
2015-07-28 14:31 ` John W. Linville
2015-07-28 16:23 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8ug8d4y.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vthiagar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).