From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:49366 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753228AbbBJNsf (ORCPT ); Tue, 10 Feb 2015 08:48:35 -0500 From: Kalle Valo To: Eric Dumazet Cc: Colin King , Larry Finger , Chaoming Li , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtlwifi: ratelimit skb allocation failure message References: <1423558471-27278-1-git-send-email-colin.king@canonical.com> <1423574228.28434.22.camel@edumazet-glaptop2.roam.corp.google.com> Date: Tue, 10 Feb 2015 15:48:26 +0200 In-Reply-To: <1423574228.28434.22.camel@edumazet-glaptop2.roam.corp.google.com> (Eric Dumazet's message of "Tue, 10 Feb 2015 05:17:08 -0800") Message-ID: <87a90lop1x.fsf@kamboji.qca.qualcomm.com> (sfid-20150210_144856_224446_B829C5A5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Eric Dumazet writes: > On Tue, 2015-02-10 at 08:54 +0000, Colin King wrote: >> From: Colin Ian King >> >> when running low on memory I noticed rtlwifi was producing a large >> quantity of repeated skb allocation failures messages. This should >> be ratelimited to reduce the noise. >> >> Signed-off-by: Colin Ian King >> --- >> drivers/net/wireless/rtlwifi/pci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c >> index c70efb9..ca0fd50 100644 >> --- a/drivers/net/wireless/rtlwifi/pci.c >> +++ b/drivers/net/wireless/rtlwifi/pci.c >> @@ -817,7 +817,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw) >> /* get a new skb - if fail, old one will be reused */ >> new_skb = dev_alloc_skb(rtlpci->rxbuffersize); >> if (unlikely(!new_skb)) { >> - pr_err("Allocation of new skb failed in %s\n", >> + pr_err_ratelimited("Allocation of new skb failed in %s\n", >> __func__); > > Or even better, remove the message. There's actually a pending patch for that, I'll send it to Dave ASAP: https://patchwork.kernel.org/patch/5671121/ -- Kalle Valo