From: Kalle Valo <kvalo@adurom.com>
To: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Cc: ext Ohad Ben-Cohen <ohad@wizery.com>,
coelho@ti.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: Allow wl12xx interrupts to wake up the host
Date: Tue, 08 Feb 2011 12:13:32 +0200 [thread overview]
Message-ID: <87aai696lv.fsf@purkki.adurom.net> (raw)
In-Reply-To: <1297151826.2064.68.camel@wimaxnb.nmp.nokia.com> (Juuso Oikarinen's message of "Tue\, 08 Feb 2011 09\:57\:06 +0200")
Juuso Oikarinen <juuso.oikarinen@nokia.com> writes:
>> > I'm currently trying to find out if this is really needed or not.
>>
>> Sure, thanks.
>
> They are saying this is needed for OMAP's retention mode too, so AFAIK
> this is needed, not just for suspend.
Why make this change in the driver? Doesn't it mean that all drivers
need to be changed so that they will work in your platform? I would
have expected that this is done automatically somewhere in the core
kernel and without any changes to the driver.
To me platform specific changes in drivers are always problematic.
--
Kalle Valo
next prev parent reply other threads:[~2011-02-08 10:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 11:30 [PATCH] wl12xx: Allow wl12xx interrupts to wake up the host juuso.oikarinen
2011-02-07 12:09 ` Ohad Ben-Cohen
2011-02-07 12:29 ` Juuso Oikarinen
2011-02-07 12:38 ` Ohad Ben-Cohen
2011-02-07 12:58 ` Juuso Oikarinen
2011-02-07 14:56 ` Ohad Ben-Cohen
2011-02-08 7:57 ` Juuso Oikarinen
2011-02-08 8:43 ` Ohad Ben-Cohen
2011-02-08 10:13 ` Kalle Valo [this message]
2011-02-08 11:13 ` Juuso Oikarinen
2011-02-08 11:47 ` Kalle Valo
2011-02-08 12:38 ` Juuso Oikarinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aai696lv.fsf@purkki.adurom.net \
--to=kvalo@adurom.com \
--cc=coelho@ti.com \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox