From: Kalle Valo <kalle.valo@nokia.com>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: chris2553@googlemail.com,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: Warning emited by 2.6.24-rc6-git5
Date: Mon, 31 Dec 2007 09:27:35 +0200 [thread overview]
Message-ID: <87abnrz5lk.fsf@nokia.com> (raw)
In-Reply-To: <200712301311.42895.IvDoorn@gmail.com> (ext Ivo van Doorn's message of "Sun\, 30 Dec 2007 13\:11\:42 +0100")
Ivo van Doorn <ivdoorn@gmail.com> writes:
> + /*
> + * Move entire frame 2 bytes to the front.
> + */
> + skb_push(skb, 2);
> + memmove(skb->data, skb->data + 2, skb->len - 2);
No skb_trim()? Shoudn't there be skb_trim(skb, 2) after memmove()?
--
Kalle Valo
next prev parent reply other threads:[~2007-12-31 7:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-29 9:42 Warning emited by 2.6.24-rc6-git5 Chris Clayton
2007-12-29 9:54 ` Johannes Berg
2007-12-29 10:21 ` Ivo van Doorn
2007-12-29 10:26 ` Johannes Berg
2007-12-29 10:36 ` Johannes Berg
2007-12-29 11:47 ` Ivo van Doorn
2007-12-29 11:59 ` Johannes Berg
2007-12-29 12:01 ` Johannes Berg
2007-12-29 14:29 ` Ivo van Doorn
2007-12-29 14:40 ` Johannes Berg
2007-12-29 15:14 ` Ivo van Doorn
2007-12-30 11:49 ` Chris Clayton
2007-12-30 12:11 ` Ivo van Doorn
2007-12-30 19:26 ` Chris Clayton
2007-12-30 22:01 ` Ivo van Doorn
2007-12-31 7:27 ` Kalle Valo [this message]
2007-12-31 7:56 ` Ivo Van Doorn
2008-01-02 6:32 ` Chris Clayton
2008-01-02 19:02 ` Ivo van Doorn
2008-01-04 17:09 ` Chris Clayton
2008-01-06 7:49 ` Andrew Price
2008-01-08 6:03 ` Chris Clayton
2008-01-02 8:11 ` Johannes Berg
2008-01-02 19:12 ` Ivo van Doorn
2008-01-08 15:44 ` Tomas Winkler
2008-01-08 17:09 ` Johannes Berg
2008-01-08 17:22 ` Johannes Berg
2008-01-08 19:43 ` Tomas Winkler
2008-01-08 20:02 ` Michael Buesch
2008-01-08 23:18 ` Tomas Winkler
2008-01-09 12:49 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87abnrz5lk.fsf@nokia.com \
--to=kalle.valo@nokia.com \
--cc=chris2553@googlemail.com \
--cc=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).