Re: [GIT PULL] mmutable branch between pdx86 amd wbrf branch and wifi / amdgpu due for the v6.8 merge window

[Kalle Valo <kvalo@kernel.org>]

Mario Limonciello <mario.limonciello@amd.com> writes:

> On 12/14/2023 10:36, Kalle Valo wrote:
>
>> Hans de Goede <hdegoede@redhat.com> writes:
>> 
>>> Hi Wifi and AMDGPU maintainers,
>>>
>>> Here is a pull-request for the platform-drivers-x86 parts of:
>>>
>>> https://lore.kernel.org/platform-driver-x86/20231211100630.2170152-1-Jun.Ma2@amd.com/
>>>
>>>  From my pov the pdx86 bits are ready and the
>>> platform-drivers-x86-amd-wbrf-v6.8-1 tag can be merged by you to merge
>>> the wifi-subsys resp. the amdgpu driver changes on top.
>>>
>>> This only adds kernel internal API, so if in the future the API
>>> needs work that can be done.
>>>
>>> I've not merged this branch into pdx86/for-next yet, since I see
>>> little use in merging it without any users. I'll merge it once either
>>> the wifi or amdgpu changes are also merged (and if some blocking
>>> issues get identified before either are merged I can prepare a new
>>> pull-request fixing the issues).
>> I was testing latest wireless-testing with ath11k and noticed this:
>> [  370.796884] ath11k_pci 0000:06:00.0: WBRF is not supported
>> I think that's just spam and not really necessary. Could someone
>> remove
>> that or change to a debug message, please?
>> 
>
> Do you have dynamic debug turned up perhaps?  It's already supposed to
> be a dbg message.
>
> +	dev_dbg(dev, "WBRF is %s supported\n",
> +		local->wbrf_supported ? "" : "not");

Oh, I should have checked that. I do have it enabled:

CONFIG_DYNAMIC_DEBUG=y
CONFIG_DYNAMIC_DEBUG_CORE=y

But that shouldn't enable the debug message unless I specifically enable
it via debugfs, right? But then I noticed this in net/mac80211/Makefile:

ccflags-y += -DDEBUG

I'm guessing this is the reason why the debug message is always printed?

It looks like wbrf.c has the only dev_dbg() call in mac80211, all others
use the macros from net/mac80211/debug.h. I think wbrf.c should also use
one of the macros from debug.h and not dev_dbg().

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches