From: Kalle Valo <kvalo@kernel.org>
To: Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org, lenb@kernel.org,
johannes@sipsolutions.net
Subject: Re: [PATCH] iwlwifi: mvm: check if SAR GEO is supported before sending command
Date: Thu, 13 Jan 2022 12:47:32 +0200 [thread overview]
Message-ID: <87bl0fud2z.fsf@kernel.org> (raw)
In-Reply-To: <iwlwifi.20220113104217.0ae07c2712dc.I14e2985bfd7ddd8a8d83eb1869b800c0e7f30db4@changeid> (Luca Coelho's message of "Thu, 13 Jan 2022 10:42:40 +0200")
Luca Coelho <luca@coelho.fi> writes:
> From: Luca Coelho <luciano.coelho@intel.com>
>
> Older hardware, for instance 3160, do not support SAR GEO offsets. We
> used to check for support before sending the command, but when moving
> the command to the init phase, we lost the check. This causes a
> failure when initializing HW that do not support this command.
>
> Fix that by adding a check before sending the command. Additionally,
> fix the caller so that it checks for the return value of the
> iwl_mvm_sar_geo_init() function, which it was ignoring.
>
> Fixes: db700bc35703 ("iwlwifi: mvm: check if SAR GEO is supported before sending command")
$ git show db700bc35703
fatal: ambiguous argument 'db700bc35703': unknown revision or path not in the working tree.
No need to resend because of this, if you can provide the commit id I
can fix the tag.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-01-13 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 8:42 [PATCH] iwlwifi: mvm: check if SAR GEO is supported before sending command Luca Coelho
2022-01-13 10:47 ` Kalle Valo [this message]
2022-01-13 12:09 ` Luca Coelho
2022-01-27 18:29 ` Luca Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl0fud2z.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=lenb@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).