From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] mac80211: use more bits for ack_frame_id
Date: Wed, 15 Jan 2020 12:42:52 +0100 [thread overview]
Message-ID: <87blr5uern.fsf@toke.dk> (raw)
In-Reply-To: <20200115122549.b9a4ef9f4980.Ied52ed90150220b83a280009c590b65d125d087c@changeid>
Johannes Berg <johannes@sipsolutions.net> writes:
> From: Johannes Berg <johannes.berg@intel.com>
>
> It turns out that this wasn't a good idea, I hit a test failure in
> hwsim due to this. That particular failure was easily worked around,
> but it raised questions: if an AP needs to, for example, send action
> frames to each connected station, the current limit is nowhere near
> enough (especially if those stations are sleeping and the frames are
> queued for a while.)
>
> Shuffle around some bits to make more room for ack_frame_id to allow
> up to 8192 queued up frames, that's enough for queueing 4 frames to
> each connected station, even at the maximum of 2007 stations on a
> single AP.
>
> We take the bits from band (which currently only 2 but I leave 3 in
> case we add another band) and from the hw_queue, which can only need
> 4 since it has a limit of 16 queues.
>
> Fixes: 6912daed05e1 ("mac80211: Shrink the size of ack_frame_id to make room for tx_time_est")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Fair enough :)
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
prev parent reply other threads:[~2020-01-15 11:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 11:25 [PATCH] mac80211: use more bits for ack_frame_id Johannes Berg
2020-01-15 11:42 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blr5uern.fsf@toke.dk \
--to=toke@redhat.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).