From: Kalle Valo <kvalo@codeaurora.org>
To: Tom Psyborg <pozega.tomislav@gmail.com>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
Ikjoon Jang <ikjn@chromium.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH] ath10k: disable cpuidle during downloading firmware.
Date: Fri, 08 Nov 2019 10:31:07 +0200 [thread overview]
Message-ID: <87bltmydkk.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CAKR_QVKqGv+hpiENHmNFE4y=FY+Mqb7cAh7_5xhTXH27HW+Taw@mail.gmail.com> (Tom Psyborg's message of "Wed, 6 Nov 2019 19:33:54 +0100")
Tom Psyborg <pozega.tomislav@gmail.com> writes:
> On 06/11/2019, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Ikjoon Jang <ikjn@chromium.org> writes:
>>
>>> Downloading ath10k firmware needs a large number of IOs and
>>> cpuidle's miss predictions make it worse. In the worst case,
>>> resume time can be three times longer than the average on sdio.
>>>
>>> This patch disables cpuidle during firmware downloading by
>>> applying PM_QOS_CPU_DMA_LATENCY in ath10k_download_fw().
>>>
>>> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
>>
>> On what hardware and firmware versions did you test this? I'll add that
>> to the commit log.
>
> I've tested this on QCA9880. No issues during firmware download.
Great, thanks for testing.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-11-08 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 5:40 [PATCH] ath10k: disable cpuidle during downloading firmware Ikjoon Jang
2019-11-06 18:22 ` Kalle Valo
2019-11-06 18:33 ` Tom Psyborg
2019-11-08 8:31 ` Kalle Valo [this message]
2019-11-07 4:16 ` Ikjoon Jang
2019-11-08 8:32 ` Kalle Valo
2019-11-08 8:54 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bltmydkk.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=ikjn@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pozega.tomislav@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).