From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE8AFA372C for ; Fri, 8 Nov 2019 08:31:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F15F02178F for ; Fri, 8 Nov 2019 08:31:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="eGMQe9cO"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="eGMQe9cO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730591AbfKHIbM (ORCPT ); Fri, 8 Nov 2019 03:31:12 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:55866 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbfKHIbM (ORCPT ); Fri, 8 Nov 2019 03:31:12 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C10526087D; Fri, 8 Nov 2019 08:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573201871; bh=34LszczZ92Bfm5fxE+0iGWvnvoA6DVyJ5WaRZ59PkCo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eGMQe9cOecy7G7/hH10g77CHW9EyERa3RktxbSQ6kcIzNbDIoAmtJbtBuxKte7GNg sHVcG1Z7rapfPeDiZ4b/jTALqatxqmOgvwfbG+XuCC+ieEqyYwGXRd4ix1zS266j8Y F4gmxiBH3nfugRryrSH0fgDrg4N3xo2stgv4nLjw= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 91CB160397; Fri, 8 Nov 2019 08:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573201871; bh=34LszczZ92Bfm5fxE+0iGWvnvoA6DVyJ5WaRZ59PkCo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eGMQe9cOecy7G7/hH10g77CHW9EyERa3RktxbSQ6kcIzNbDIoAmtJbtBuxKte7GNg sHVcG1Z7rapfPeDiZ4b/jTALqatxqmOgvwfbG+XuCC+ieEqyYwGXRd4ix1zS266j8Y F4gmxiBH3nfugRryrSH0fgDrg4N3xo2stgv4nLjw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 91CB160397 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Tom Psyborg Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, Ikjoon Jang , "David S . Miller" Subject: Re: [PATCH] ath10k: disable cpuidle during downloading firmware. References: <20191101054035.42101-1-ikjn@chromium.org> <87y2ws3lvh.fsf@kamboji.qca.qualcomm.com> Date: Fri, 08 Nov 2019 10:31:07 +0200 In-Reply-To: (Tom Psyborg's message of "Wed, 6 Nov 2019 19:33:54 +0100") Message-ID: <87bltmydkk.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Tom Psyborg writes: > On 06/11/2019, Kalle Valo wrote: >> Ikjoon Jang writes: >> >>> Downloading ath10k firmware needs a large number of IOs and >>> cpuidle's miss predictions make it worse. In the worst case, >>> resume time can be three times longer than the average on sdio. >>> >>> This patch disables cpuidle during firmware downloading by >>> applying PM_QOS_CPU_DMA_LATENCY in ath10k_download_fw(). >>> >>> Signed-off-by: Ikjoon Jang >> >> On what hardware and firmware versions did you test this? I'll add that >> to the commit log. > > I've tested this on QCA9880. No issues during firmware download. Great, thanks for testing. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches